From 7d9986dd4bf09ca2dc29d81e43cf616ede8f54b1 Mon Sep 17 00:00:00 2001 From: Mason James Date: Tue, 15 Apr 2014 00:11:16 +1200 Subject: [PATCH] Bug 10823 - add class info to enumchron data in detail.tt, for better styling Bug 10825 removes a duplicate (enumchron==serialseq). This patch was developed on top of it. It properly styles the elements. These include: - items.enumchron - the separator used - serial.serialseq - items.publisheddate As per Katrin's and Owen's suggestion, was used instead of
. (See comment #7 and http://irc.koha-community.org/koha/2014-04-03#i_1491135) TEST PLAN --------- 1) Apply patch 10825 2) Find a biblio where the enumchron and serialseq are different. -- in MySQL: SELECT items.biblionumber,items.enumchron,serial.serialseq FROM items,serial,serialitems WHERE items.itemnumber=serilaitems.itemnumber AND serialitems.serialid=serial.serialid; 3) In the staff client, view the source for that item. -- It should be one class for the entire cell. 4) Apply patch 10823 5) Refresh the page 6) Look at the source for that item again. -- It should have tags around the 4 things listed above. 7) Run the koha qa test tools. Signed-off-by: Mark Tompsett NOTE: Since there was lots of squashing and rebasing, could you please test and sign this off as well, Mason? --- .../prog/en/modules/catalogue/detail.tt | 16 +++++++++------- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt index d09a3c4..97c4267d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt @@ -659,17 +659,19 @@ function verify_images() { [% IF ( itemdata_enumchron ) %] [% IF item.enumchron && item.serialseq %] - [% item.enumchron %] - [% IF ( item.serialseq && - item.enumchron!=item.serialseq ) %] - -- [% item.serialseq %] + [% item.enumchron %] + [% IF ( item.serialseq && item.enumchron!=item.serialseq ) %] + -- + [% item.serialseq %] [% END %] [% ELSIF item.enumchron %] - [% item.enumchron %] + [% item.enumchron %] [% ELSIF item.serialseq %] - [% item.serialseq %] + [% item.serialseq %] + [% END %] + [% IF ( item.publisheddate ) %] + ([% item.publisheddate %]) [% END %] - [% IF ( item.publisheddate ) %] ([% item.publisheddate %])[% END %] [% END %] [% END %] -- 1.7.9.5