From 4f78b083002eeda70147f211e367739ad497daae Mon Sep 17 00:00:00 2001 From: Benjamin Rokseth Date: Tue, 22 Apr 2014 14:09:16 +0200 Subject: [PATCH] [SIGNED-OFF] Bug 12122: TransferSlip should accept both itemnumber and barcode Content-Type: text/plain; charset="utf-8" Added small patch to allow barcode as input in TransferSlip routine, mostly to allow generating transfer slips where only barcode is present (aka. javascript). Test plan: 1) find book with and 2) generate transferslips with both: transfer-slip.pl?transferitem=3967925&branchcode=MPL&op=slip transfer-slip.pl?barcode=&branchcode=MPL&op=slip and verify that the generated slips match. Signed-off-by: Owen Leonard --- C4/Circulation.pm | 4 ++-- circ/transfer-slip.pl | 3 ++- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index bd9e1cc..9856f17 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -3594,9 +3594,9 @@ sub ProcessOfflinePayment { =cut sub TransferSlip { - my ($branch, $itemnumber, $to_branch) = @_; + my ($branch, $itemnumber, $barcode, $to_branch) = @_; - my $item = GetItem( $itemnumber ) + my $item = GetItem( $itemnumber, $barcode ) or return; my $pulldate = C4::Dates->new(); diff --git a/circ/transfer-slip.pl b/circ/transfer-slip.pl index c8e97a0..c6077d4 100755 --- a/circ/transfer-slip.pl +++ b/circ/transfer-slip.pl @@ -38,6 +38,7 @@ my $sessionID = $input->cookie("CGISESSID"); my $session = get_session($sessionID); my $itemnumber = $input->param('transferitem'); +my $barcode = $input->param('barcode'); my $branchcode = $input->param('branchcode'); my ( $template, $loggedinuser, $cookie ) = get_template_and_user( @@ -54,7 +55,7 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user( my $userenv = C4::Context->userenv; my ($slip, $is_html); -if ( my $letter = TransferSlip ($session->param('branch') || $userenv->{branch}, $itemnumber, $branchcode) ) { +if ( my $letter = TransferSlip ($session->param('branch') || $userenv->{branch}, $itemnumber, $barcode, $branchcode) ) { $slip = $letter->{content}; $is_html = $letter->{is_html}; } -- 1.7.9.5