From 51684d346835ca50b39a8c8a141be45c651d5869 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Tue, 15 Apr 2014 16:31:18 +0200 Subject: [PATCH] Bug 7180: QA followup 2 This patch takes into account all QA failures raised in comment 207. --- acqui/addorderiso2709.pl | 2 +- .../intranet-tmpl/prog/en/css/staff-global.css | 6 ++++++ koha-tmpl/intranet-tmpl/prog/en/js/acq.js | 3 +++ .../prog/en/modules/acqui/addorderiso2709.tt | 21 ++++++++++---------- .../en/modules/admin/preferences/acquisitions.pref | 3 ++- 5 files changed, 23 insertions(+), 12 deletions(-) diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl index 54c4414..f3c124e 100755 --- a/acqui/addorderiso2709.pl +++ b/acqui/addorderiso2709.pl @@ -174,7 +174,7 @@ if ($op eq ""){ my $c_quantity = shift( @quantities ) || GetMarcQuantity($marcrecord, C4::Context->preference('marcflavour') ) || 1; my $c_budget_id = shift( @budgets_id ) || $input->param('all_budget_id') || $budget_id; my $c_discount = shift ( @discount); - $c_discount = $c_discount / 100 if $c_discount > 100; + $c_discount = $c_discount / 100 if $c_discount > 1; my $c_sort1 = shift( @sort1 ) || $input->param('all_sort1') || ''; my $c_sort2 = shift( @sort2 ) || $input->param('all_sort2') || ''; diff --git a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css index 8abe90d..7c7a5d9 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css +++ b/koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css @@ -554,6 +554,12 @@ padding: 0; width: 100%; } +fieldset.rows.unselected { + background-color: white; + border-width : 0px; + border: 0; +} + fieldset.rows legend { margin-left: 1em; font-weight: bold; diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/acq.js b/koha-tmpl/intranet-tmpl/prog/en/js/acq.js index c2c3cf2..3bac18b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/js/acq.js +++ b/koha-tmpl/intranet-tmpl/prog/en/js/acq.js @@ -215,6 +215,9 @@ function calcNewsuggTotal(){ } function getAuthValueDropbox( name, cat, destination, selected ) { + if ( typeof(selected) == 'undefined' ) { + selected = ""; + } if (cat == null || cat == "") { $(destination).replaceWith(' ' ); return; diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt index c1af7ea..fcbe4d0 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt @@ -151,8 +151,8 @@
- Check All - Uncheck All + Check all + Uncheck all @@ -170,9 +170,9 @@ [% biblio.citation %] - ( Show MARC | Card ; Add order ) - - + + ( MARC | Card | Add order ) +
  1. @@ -201,7 +201,7 @@
  2. - + %
  3. @@ -221,11 +221,11 @@ [% END %]
  4. - +
  5. - +
@@ -271,6 +271,7 @@ [% END %]
+

Import all the checked items in the basket with the following accounting details (used only if no information is filled for the item):

Accounting details
    @@ -319,7 +320,7 @@
  1. The 2 following fields are available for your own usage. They can be useful for statistical purposes
    - + [% IF CGIsort1 %] [% FOREACH sort_opt IN CGIsort2 %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref index 008d214..66829e7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/acquisitions.pref @@ -49,7 +49,8 @@ Acquisitions: - Set the mapping values for a new order line created from a marcrecord (staged file). - pref: MarcFieldsToOrder type: textarea - - "For example:
    price: 947$a|947$c
    quantity: 969$h
    budget_code: 922$a" + - "You can use the following fields: price, quantity, budget_code, discount, sort1, sort2" + - "
    For example:
    price: 947$a|947$c
    quantity: 969$h
    budget_code: 922$a" Printing: - - Use the -- 1.7.10.4