From 0f4f2444d68ff0a2d48bb202e95c2907d6458763 Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Wed, 11 Dec 2013 12:45:22 +0100 Subject: [PATCH] [SIGNED-OFF] Bug 5010: Send list emails with complete links back into the catalog This patch adapts the way the links in the cart email in OPAC are generated for the list emails. The OpacBaseURL variable is generated from code in Auth.pm. To test: - Create a list - Email yourself the list Note: Email is sent directly and not via messagequeue table - Verify the links back into the catalog are missing http(s):// - Apply the patch - Email yourself the list again - Verify the links are now ok and working Note: The way Auth.pm generates the OpacBaseURL is not correct, as it does not take into account the OpacBaseURL system preference. This patch makes both emails sent from OPAC rely on the same code and is an improvement over the current behaviour. Tested both together using steps similar to larger test plan. Signed-off-by: Mark Tompsett Signed-off-by: Bernardo Gonzalez Kriegel Just add a sign. --- opac/opac-sendshelf.pl | 4 ---- 1 file changed, 4 deletions(-) diff --git a/opac/opac-sendshelf.pl b/opac/opac-sendshelf.pl index 3f9b719..470282a 100755 --- a/opac/opac-sendshelf.pl +++ b/opac/opac-sendshelf.pl @@ -107,10 +107,6 @@ if ( $email ) { my $user = GetMember(borrowernumber => $borrowernumber); - if (C4::Context->preference('OPACBaseURL')){ - $template2->param( OPACBaseURL => C4::Context->preference('OPACBaseURL') ); - } - $template2->param( BIBLIO_RESULTS => \@results, email_sender => $email_from, -- 1.7.9.5