From 00e9b75b6ffd246fa90e15c39b69d7dd184d6d2e Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Thu, 13 Mar 2014 11:30:15 -0300 Subject: [PATCH] [PASSED QA] Bug 10942: (QA followup) Warnings should go to STDERR As noted by Robin, STDOUT is used by the script to communicate with debconf and, ence, the warning messages should be directed to STDERR. This patch does that. To test: - Set AUTOMATIC_TRANSLATIONS_UPDATE="no" so the warning normally shows - Redirect STDOUT to /dev/null: dpkg -i koha-common...deb > /dev/null => Warning message doesn't show (i.e. it is sent to STDOUT) - Apply the patch, rebuild package - Redirect STDOUT to /dev/null: dpkg -i koha-common...deb > /dev/null => Warning message shows (i.e. is correctly sent to STDERR) - Redirect STDERR to /dev/null: dpkg -i koha-common...deb 2> /dev/null => Warning message doesn't show - Verify that previous tests pass Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize --- debian/koha-common.postinst | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/debian/koha-common.postinst b/debian/koha-common.postinst index 47acd42..f22bcb0 100644 --- a/debian/koha-common.postinst +++ b/debian/koha-common.postinst @@ -59,7 +59,7 @@ if [ "$AUTOMATIC_TRANSLATIONS_UPDATE" = "yes" ]; then if koha-translate --update $lang; then echo "Updated the $lang translations." else - cat <&2 ERROR: an error was found when updating '$lang' translations. Please manually run 'koha-translate --update $lang'. Run man koha-translate for more options. EOF @@ -69,7 +69,7 @@ else # no auto-update, check update needed and warn if needed if koha-translate --list | grep -v -q -x "en"; then # translations installed, update needed - cat <&2 Warning: template translations are not set to be automatically updated. Please manually run 'koha-translate --update lang_code' to update them. -- 1.7.10.4