Bugzilla – Attachment 27535 Details for
Bug 11719
Use new DataTables include in serials templates
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11719 [Follow-up 2] Use new DataTables include in serials templates
Bug-11719-Follow-up-2-Use-new-DataTables-include-i.patch (text/plain), 3.77 KB, created by
Chris Cormack
on 2014-04-24 13:19:42 UTC
(
hide
)
Description:
Bug 11719 [Follow-up 2] Use new DataTables include in serials templates
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2014-04-24 13:19:42 UTC
Size:
3.77 KB
patch
obsolete
>From f72d2dac432c26aa64b637ba795a930b7e72e4a2 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Tue, 15 Apr 2014 15:32:34 -0400 >Subject: [PATCH] Bug 11719 [Follow-up 2] Use new DataTables include in serials > templates > >This second follow-up addresses QA issues: > >- Corrected sorting on claims page while converting sorting > configuration to up-to-date method. >- Removed sorting from routing list column on serial collection page. > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > .../prog/en/modules/serials/claims.tt | 23 ++++++++++------------ > .../prog/en/modules/serials/serials-collection.tt | 6 +----- > 2 files changed, 11 insertions(+), 18 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >index df18395..34c6d8c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/claims.tt >@@ -12,18 +12,15 @@ > [% UNLESS ( preview ) %] > var sTable = $("#claimst").dataTable($.extend(true, {}, dataTablesDefaults, { > "sDom": 't', >- [% IF ( letter ) %] > "aoColumnDefs": [ >- { "aTargets": [ 0,1 ], "bSortable": false, "bSearchable": false } >+ [% IF ( letter ) %] >+ { "aTargets": [ 0,1 ], "bSortable": false, "bSearchable": false }, >+ [% ELSE %] >+ { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false }, >+ [% END %] >+ { 'sType': "anti-the", 'aTargets' : [ 'anti-the'] }, >+ { 'sType': "title-string", 'aTargets' : [ 'title-string'] } > ], >- [% ELSE %] >- "aoColumnDefs": [ >- { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false } >- ], >- [% END %] >- "aoColumns": [ >- [% IF ( letter ) %]null,[% END %]null,null,{ "sType": "anti-the" },null,null,{ "sType": "title-string" },{ "sType": "title-string" } >- ], > "bPaginate": false > })); > [% END %] >@@ -268,12 +265,12 @@ > <th><input type="checkbox" id="CheckAll"></th> > <th>Vendor</th> > <th>Library</th> >- <th>Title</th> >+ <th class="anti-the">Title</th> > <th>ISSN</th> > <th>Issue number</th> > <th>Status</th> >- <th>Since</th> >- <th>Claim date</th> >+ <th class="title-string">Since</th> >+ <th class="title-string">Claim date</th> > </tr></thead> > <tbody>[% FOREACH missingissue IN missingissues %] > <tr> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >index 894773a..426c602 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt >@@ -60,13 +60,9 @@ function CheckNone( node ) { > } > $(document).ready(function() { > $('#subscription_years').tabs(); >- [% IF dateformat == "metric" %] >- dt_add_type_uk_date(); >- [% END %] >- > $(".subscription-year-table").dataTable($.extend(true, {}, dataTablesDefaults, { > "aoColumnDefs": [ >- { "aTargets": [ 0 ], "bSortable": false, "bSearchable": false }, >+ { "aTargets": [ 0,-1 ], "bSortable": false, "bSearchable": false }, > { "sType": "title-string", "aTargets" : [ "title-string" ] } > ], > "aaSorting": [[0, 'desc']], >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11719
:
25178
|
25600
|
25619
|
26042
|
26043
|
27145
|
27535
|
27733
|
27734
|
27735
|
27737
|
27738
|
27739