Bugzilla – Attachment 27618 Details for
Bug 12046
Authentication using CAS - bootstrap
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12046: Authentication using CAS - bootstrap
Bug-12046-Authentication-using-CAS---bootstrap.patch (text/plain), 2.79 KB, created by
Fridolin Somers
on 2014-04-25 12:55:43 UTC
(
hide
)
Description:
Bug 12046: Authentication using CAS - bootstrap
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-04-25 12:55:43 UTC
Size:
2.79 KB
patch
obsolete
>From 9c80235a11e3e913db3a6d91b3cbfce4bdbea5bc Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 8 Apr 2014 16:48:31 +0200 >Subject: [PATCH] Bug 12046: Authentication using CAS - bootstrap > >At the OPAC, if the bootstrap theme is used, the modal dialog does not allow to use the CAS authentication. > >This patch proposes, in case CAS is enabled, to redirect to the opac-user.pl page (like prog theme). >This is because the popup content should stay small (thinking about mobile surf), and that CAS url is actually only computed in opac-user (see C4/Auth.pm) and it would not be performant to compute it in all pages. > >Test plan: >- set syspref opacthemes to bootstrap >- enable the casAuthentication syspref >- fill the casServerUrl syspref with something like : https://localhost:8443/cas >- go on the opac home page >- click on "Log in to your account" link (top right) >=> You go to cgi-bin/koha/opac-user.pl page where you see the cas link >- disable the casAuthentication syspref >- go on the opac home page >- click on "Log in to your account" link (top right) >=> You see a popup for loggin and password >--- > koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >index 1edc244..942f640 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc >@@ -71,7 +71,12 @@ > <div id="members"> > <ul class="nav pull-right"> > [% UNLESS ( loggedinusername ) %] >- <li><a href="/cgi-bin/koha/opac-user.pl" class="loginModal-trigger" role="button" data-toggle="modal">Log in to your account</a></li> >+ [% IF Koha.Preference('casAuthentication') %] >+ [%# CAS authentication is too complicated for modal window %] >+ <li><a href="/cgi-bin/koha/opac-user.pl">Log in to your account</a></li> >+ [% ELSE %] >+ <li><a href="/cgi-bin/koha/opac-user.pl" class="loginModal-trigger" role="button" data-toggle="modal">Log in to your account</a></li> >+ [% END %] > [% END %] > [% IF ( loggedinusername ) %] > <li><p class="members navbar-text">Welcome, <a href="/cgi-bin/koha/opac-user.pl"><span class="loggedinusername">[% FOREACH USER_INF IN USER_INFO %][% USER_INF.title %] [% USER_INF.firstname %] [% USER_INF.surname %][% END %]</span></a></p></li> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12046
:
26902
|
26904
|
26931
|
27618
|
27628
|
27647