From 9372d26ada0fcd177c6d4c2cf67990096960f2aa Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 6 May 2014 12:26:49 -0400 Subject: [PATCH] Bug 12198 - Guarantor search makes incorrect and unnecessary call to GetMemberIssuesAndFines The script members/guarantor_search.pl makes the following call: my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); Not only does this call always fail because borrowerid is not a valid key, but the results are never even used in the template! Test Plan: 1) Apply this patch 2) Verify the gurantor search works as before, No changes in behavior should be noted --- members/guarantor_search.pl | 3 --- 1 files changed, 0 insertions(+), 3 deletions(-) diff --git a/members/guarantor_search.pl b/members/guarantor_search.pl index 59ea5b1..42d36a7 100755 --- a/members/guarantor_search.pl +++ b/members/guarantor_search.pl @@ -71,7 +71,6 @@ if ($member ne ''){ for (my $i=0; $i < $count; $i++){ #find out stats - my ($od,$issue,$fines)=GetMemberIssuesAndFines($results->[$i]{'borrowerid'}); my $guarantorinfo=uc($results->[$i]{'surname'})." , ".ucfirst($results->[$i]{'firstname'}); my %row = ( background => $background, @@ -94,8 +93,6 @@ if ($member ne ''){ dateofbirth =>format_date($results->[$i]{'dateofbirth'}), #fi op - odissue => "$od/$issue", - fines => $fines, borrowernotes => $results->[$i]{'borrowernotes'}); if ( $background ) { $background = 0; } else {$background = 1; } push(@resultsdata, \%row); -- 1.7.2.5