From 59df0f2125d5846996854e711cb5458a55cf15c0 Mon Sep 17 00:00:00 2001 From: Fridolin Somers Date: Tue, 20 May 2014 12:38:05 +0200 Subject: [PATCH] Bug 12291 - remove acronym for CAS (bootstrap) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The HTML tag acronym is obsolete for HTML5 and also complicates translation. In sources :

If you have a CAS account, It generates : msgid "If you have a " msgid "Central Authentication Service" msgid "account, %s please " This is difficult to translate correctly because strings are splitted. For example in French, the translation is actually : msgid "Si vous avez un " msgid "Central Authentication Service (Service d'Identification Centralisé)" msgid "compte, %s s'il vous plait " It generates :

Si vous avez un CAS compte, %s s'il vous plait. It should be :

Si vous avez un compte CAS, %s s'il vous plait. This patch removes the acronym tag and moves the title attribute to the h4 tag. Test plan : - Enable OPAC bootstrap theme - Enable casAuthentication - Go to login page /cgi-bin/koha/opac-user.pl => Without patch you see "If you have a CAS account", CAS is a acronym tag. => With patch you see "If you have a CAS account" without acronym tag and "CAS login" has a title "Login via Central Authentication Service" --- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt index e031d90..54bf1da 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt @@ -58,14 +58,14 @@ [% END %] [% IF ( casAuthentication ) %] -

CAS login

+

CAS login

[% IF ( invalidCasLogin ) %]

Sorry, the CAS login failed.

[% END %] -

If you have a CAS account, +

If you have a CAS account, [% IF ( casServerUrl ) %] please click here to login.

[% END %] -- 1.9.1