Bugzilla – Attachment 28347 Details for
Bug 12291
Replace the acronym HTML tag with abbr
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12291 - remove acronym for CAS (bootstrap)
Bug-12291---remove-acronym-for-CAS-bootstrap.patch (text/plain), 2.89 KB, created by
Fridolin Somers
on 2014-05-20 10:42:32 UTC
(
hide
)
Description:
Bug 12291 - remove acronym for CAS (bootstrap)
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2014-05-20 10:42:32 UTC
Size:
2.89 KB
patch
obsolete
>From 59df0f2125d5846996854e711cb5458a55cf15c0 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 20 May 2014 12:38:05 +0200 >Subject: [PATCH] Bug 12291 - remove acronym for CAS (bootstrap) >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >The HTML tag acronym is obsolete for HTML5 and also complicates translation. > >In sources : > <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, >It generates : > msgid "If you have a " > msgid "Central Authentication Service" > msgid "account, %s please " >This is difficult to translate correctly because strings are splitted. >For example in French, the translation is actually : > msgid "Si vous avez un " > msgid "Central Authentication Service (Service d'Identification Centralisé)" > msgid "compte, %s s'il vous plait " >It generates : > <p>Si vous avez un <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym> compte, %s s'il vous plait. >It should be : > <p>Si vous avez un compte <acronym title="Central Authentication Service (Service d'Identification Centralisé)">CAS</acronym>, %s s'il vous plait. > >This patch removes the acronym tag and moves the title attribute to the h4 tag. > >Test plan : >- Enable OPAC bootstrap theme >- Enable casAuthentication >- Go to login page /cgi-bin/koha/opac-user.pl >=> Without patch you see "If you have a CAS account", CAS is a acronym tag. >=> With patch you see "If you have a CAS account" without acronym tag and "CAS login" has a title "Login via Central Authentication Service" >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >index e031d90..54bf1da 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-auth.tt >@@ -58,14 +58,14 @@ > [% END %] > > [% IF ( casAuthentication ) %] >- <h4>CAS login</h4> >+ <h4 title="Login via Central Authentication Service">CAS login</h4> > > [% IF ( invalidCasLogin ) %] > <!-- This is what is displayed if cas login has failed --> > <p>Sorry, the CAS login failed.</p> > [% END %] > >- <p>If you have a <acronym title="Central Authentication Service">CAS</acronym> account, >+ <p>If you have a CAS account, > [% IF ( casServerUrl ) %] > please <a href="[% casServerUrl %]">click here to login</a>.<p> > [% END %] >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12291
:
28347
|
28348
|
36064
|
36569
|
36572
|
36574
|
36580
|
36581