Bugzilla – Attachment 28395 Details for
Bug 12274
Closed invoices not properly handled on invoice details page
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12274 - Closed invoices not properly handled on invoice details page
PASSED-QA-Bug-12274---Closed-invoices-not-properly.patch (text/plain), 1.70 KB, created by
Katrin Fischer
on 2014-05-21 10:31:35 UTC
(
hide
)
Description:
[PASSED QA] Bug 12274 - Closed invoices not properly handled on invoice details page
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-05-21 10:31:35 UTC
Size:
1.70 KB
patch
obsolete
>From 3e90cee8c0965b05320c38758dc2d4316fdb067c Mon Sep 17 00:00:00 2001 >From: Jacek Ablewicz <abl@biblos.pk.edu.pl> >Date: Sat, 17 May 2014 10:30:15 +0200 >Subject: [PATCH] [PASSED QA] Bug 12274 - Closed invoices not properly handled > on invoice details page > >Trivial fix for small regression (closed invoices are displayed as >"Open" on details page, and it's not possible to reopen the closed >invoice using "Save" button) introduced by bug 10613. > >Test plan: > >1) Create and close some invoices >2) Note that closed invoices are erroneously displayed as "Open" >on individual invoice[s] details page >3) Apply patch >4) Check previously closed invoices; their status on details page >should now be properly displayed as "Closed on ..." (and an option >for reopening would reappear as well) >5) Ensure that "Close" / "Reopen" checkboxes followed by "Save" button >do work as expected for individual open / closed invoices respectivelly. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described. >--- > acqui/invoice.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/acqui/invoice.pl b/acqui/invoice.pl >index 95065c9..84b7834 100755 >--- a/acqui/invoice.pl >+++ b/acqui/invoice.pl >@@ -151,7 +151,7 @@ $template->param( > booksellerid => $details->{'booksellerid'}, > datereceived => $details->{'datereceived'}, > billingdate => C4::Dates->new($details->{'billingdate'}, "iso")->output(), >- invoiceclosedate => $details->{'invoiceclosedate'}, >+ invoiceclosedate => $details->{'closedate'}, > shipmentcost => $details->{'shipmentcost'}, > orders_loop => \@orders_loop, > foot_loop => \@foot_loop, >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12274
:
28303
|
28351
|
28352
| 28395 |
28396