From aed22daf2979188a3edc20a77571e61aea7186f9 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Wed, 21 May 2014 07:14:50 -0400 Subject: [PATCH] Bug 12025 - Inventory tool fails with "Could not reads headers", or sometimes a timeout Content-Type: text/plain; charset=utf-8 For libraries with large numbers of records, using a file of barcodes in the inventory tool without selecting filters to limit the catalog selection to compare against can result in an error of "could not read headers" or a page timeout. When you upload a file of barcodes, and do not specify any filters on the rest of the form, it effectively runs GetItemsForInventory() such that *every* item in the database is returned. On a large enough database, this takes so long that the script times out. The current documentation in the manual implies that if you upload a file of barcodes, the *only* thing it does is set the date-last-seen field. This is not entirely true; it also tries to compare the list of scanned items to what is expected to be seen in the list of items. The work-around for libraries with a large number of item records is to, when uploading a file of barcodes, to also set the filters (e.g., library, shelving location, call number range, etc.) to specify the range of items that the file of barcodes corresponds to. This patch adds a warning when a librarian attempts to upload a barcode list file for comparison without selecting any filters to limit the catalog selection. Test Plan: 1) Apply this patch 2) Browse to the inventory tool 3) Click the "Choose File" button, select a file 4) Click the "Submit" button 5) You should see a warning message 6) Click "Cancel" 7) Select one of more filters 8) Click the "Submit" button 9) This time the script should proceed without triggering the warning. Signed-off-by: Bernardo Gonzalez Kriegel Work as described following test plan. No errors Signed-off-by: Marcel de Rooy --- .../prog/en/modules/tools/inventory.tt | 29 +++++++++++++++----- 1 files changed, 22 insertions(+), 7 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt index c8034c3..c2d9a8c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt @@ -8,8 +8,27 @@