Bugzilla – Attachment 28943 Details for
Bug 12395
Save order line's creator
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12395: Save order line's creator
0001-Bug-12395-Save-order-line-s-creator.patch (text/plain), 10.85 KB, created by
Paola Rossi
on 2014-06-18 14:53:58 UTC
(
hide
)
Description:
Bug 12395: Save order line's creator
Filename:
MIME Type:
Creator:
Paola Rossi
Created:
2014-06-18 14:53:58 UTC
Size:
10.85 KB
patch
obsolete
>From 5a242023f9dd631e00ae3809f8a26f1ac65fb60b Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Mon, 9 Jun 2014 16:15:17 +0200 >Subject: [PATCH] Bug 12395: Save order line's creator > >New MySQL column: aqorders.createdby > >Creator's name is displayed on order's receive pages (acqui/orderreceive.pl >and acqui/parcel.pl) > >On acqui/orderreceive.pl it replace the name of basket's creator >On acqui/parcel.pl, to avoid adding more data in the table of pending >orders, it is shown in a popup like MARC and Card views > >Test plan: >1/ Run updatedatabase.pl >2/ Create a new order and go to the receipt page (acqui/parcel.pl) >3/ Click on "Order" link in column "More" (previously "View record") >4/ A javascript popup should appear with your name in it. Close the >popup. >5/ Click on "Receive" link >6/ Your name should appear in front of "Created by" label, to the right >of the page. > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> >--- > C4/Acquisition.pm | 8 +++- > acqui/orderreceive.pl | 6 +-- > acqui/showorder.pl | 44 ++++++++++++++++++++ > installer/data/mysql/kohastructure.sql | 1 + > installer/data/mysql/updatedatabase.pl | 10 +++++ > .../prog/en/modules/acqui/orderreceive.tt | 14 ++++++- > .../intranet-tmpl/prog/en/modules/acqui/parcel.tt | 8 +++- > .../prog/en/modules/acqui/showorder.tt | 39 +++++++++++++++++ > 8 files changed, 122 insertions(+), 8 deletions(-) > create mode 100755 acqui/showorder.pl > create mode 100644 koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt > >diff --git a/C4/Acquisition.pm b/C4/Acquisition.pm >index 2e013ac..22559c6 100644 >--- a/C4/Acquisition.pm >+++ b/C4/Acquisition.pm >@@ -1265,12 +1265,18 @@ sub NewOrder { > my $dbh = C4::Context->dbh; > my @params; > >- > # if these parameters are missing, we can't continue > for my $key (qw/basketno quantity biblionumber budget_id/) { > croak "Mandatory parameter $key missing" unless $orderinfo->{$key}; > } > >+ if (not defined $orderinfo->{createdby}) { >+ my $userenv = C4::Context->userenv; >+ if ($userenv) { >+ $orderinfo->{createdby} = $userenv->{number}; >+ } >+ } >+ > if ( defined $orderinfo->{subscription} && $orderinfo->{'subscription'} eq 'yes' ) { > $orderinfo->{'subscription'} = 1; > } else { >diff --git a/acqui/orderreceive.pl b/acqui/orderreceive.pl >index 50920e0..5262c15 100755 >--- a/acqui/orderreceive.pl >+++ b/acqui/orderreceive.pl >@@ -190,8 +190,7 @@ if ( $bookseller->{listincgst} ) { > > my $suggestion = GetSuggestionInfoFromBiblionumber($order->{biblionumber}); > >-my $authorisedby = $order->{authorisedby}; >-my $member = GetMember( borrowernumber => $authorisedby ); >+my $creator = GetMember( borrowernumber => $order->{createdby} ); > > my $budget = GetBudget( $order->{budget_id} ); > >@@ -216,8 +215,7 @@ $template->param( > quantityreceived => $order->{'quantityreceived'}, > rrp => sprintf( "%.2f", $rrp ), > ecost => sprintf( "%.2f", $ecost ), >- memberfirstname => $member->{firstname} || "", >- membersurname => $member->{surname} || "", >+ creator => $creator, > invoiceid => $invoice->{invoiceid}, > invoice => $invoice->{invoicenumber}, > datereceived => $datereceived->output(), >diff --git a/acqui/showorder.pl b/acqui/showorder.pl >new file mode 100755 >index 0000000..048eb9f >--- /dev/null >+++ b/acqui/showorder.pl >@@ -0,0 +1,44 @@ >+#!/usr/bin/perl >+ >+# This file is part of Koha. >+# >+# Koha is free software; you can redistribute it and/or modify it under the >+# terms of the GNU General Public License as published by the Free Software >+# Foundation; either version 2 of the License, or (at your option) any later >+# version. >+# >+# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >+# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >+# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# >+# You should have received a copy of the GNU General Public License along >+# with Koha; if not, write to the Free Software Foundation, Inc., >+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+ >+use Modern::Perl; >+use CGI; >+ >+use C4::Auth; >+use C4::Acquisition; >+use C4::Members; >+use C4::Output; >+ >+my $cgi = new CGI; >+my ( $template, $loggedinuser, $cookie ) = get_template_and_user({ >+ template_name => "acqui/showorder.tt", >+ query => $cgi, >+ type => "intranet", >+ authnotrequired => 0, >+ flagsrequired => { acquisition => '*' }, >+}); >+ >+my $ordernumber = $cgi->param('ordernumber'); >+my $order = GetOrder($ordernumber); >+my $creator = GetMember(borrowernumber => $order->{createdby}); >+ >+$template->param( >+ order => $order, >+ creator => $creator, >+); >+ >+output_html_with_http_headers $cgi, $cookie, $template->output; >diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql >index b46dc6a..dcfb895 100644 >--- a/installer/data/mysql/kohastructure.sql >+++ b/installer/data/mysql/kohastructure.sql >@@ -3002,6 +3002,7 @@ CREATE TABLE `aqorders` ( -- information related to the basket line items > `freight` decimal(28,6) default NULL, -- shipping costs (not used) > `unitprice` decimal(28,6) default NULL, -- the actual cost entered when receiving this line item > `quantityreceived` smallint(6) NOT NULL default 0, -- the quantity that have been received so far >+ createdby int(11) NULL DEFAULT NULL, -- the borrowernumber of order line's creator > `cancelledby` varchar(10) default NULL, -- not used? always NULL > `datecancellationprinted` date default NULL, -- the date the line item was deleted > `order_internalnote` mediumtext, -- notes related to this order line, made for staff >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index c68ba51..b742f0a 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -8560,6 +8560,16 @@ if ( CheckVersion($DBversion) ) { > SetVersion($DBversion); > } > >+$DBversion = "XXX"; >+if ( CheckVersion($DBversion) ) { >+ $dbh->do(q{ >+ ALTER TABLE aqorders >+ ADD COLUMN createdby int(11) NULL DEFAULT NULL AFTER quantityreceived >+ }); >+ print "Upgrade to $DBversion done (Bug 12395: Add aqorders.createdby column)\n"; >+ SetVersion ($DBversion); >+} >+ > =head1 FUNCTIONS > > =head2 TableExists($table) >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >index 422a4a3..64a0873 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/orderreceive.tt >@@ -279,7 +279,19 @@ > [% END %] > </select></li> > <li><label> </label><span>(Current: [% budget_period_description %] - [% bookfund %])</span></li> >- <li><label for="creator">Created by: </label><span> [% IF ( memberfirstname and membersurname ) %][% IF ( memberfirstname ) %][% memberfirstname %][% END %] [% membersurname %][% ELSE %]No name[% END %]</span></li> >+ <li> >+ <label for="creator">Created by: </label> >+ <span> >+ [% IF (creator && creator.firstname && creator.surname) %] >+ [% IF creator.firstname %] >+ [% creator.firstname %] >+ [% END %] >+ [% creator.surname %] >+ [% ELSE %] >+ No name >+ [% END %] >+ </span> >+ </li> > <li><label for="quantity_to_receive">Quantity to receive: </label><span class="label"> > [% IF ( edit and not subscriptionid) %] > <input type="text" id="quantity_to_receive" name="quantity" value="[% quantity %]" /> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >index 69c047d..019806e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcel.tt >@@ -243,7 +243,7 @@ > <th>Basket group</th> > <th>Order line</th> > <th>Summary</th> >- <th>View record</th> >+ <th>More</th> > <th>Quantity</th> > <th>Unit cost</th> > <th>Order cost</th> >@@ -286,7 +286,11 @@ > [<a href="/cgi-bin/koha/acqui/modordernotes.pl?ordernumber=[% loop_order.ordernumber %]&referrer=/cgi-bin/koha/acqui/parcel.pl%3Finvoiceid=[% invoiceid %]&type=vendor">Add vendor note</a>] > [% END %] > </td> >- <td><a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">MARC</a> | <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">Card</a></td> >+ <td> >+ <a href="/cgi-bin/koha/acqui/showorder.pl?ordernumber=[% loop_order.ordernumber %]" title="Order" rel="gb_page_center[600,500]">Order</a><br> >+ <a href="/cgi-bin/koha/catalogue/showmarc.pl?id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">MARC</a><br> >+ <a href="/cgi-bin/koha/catalogue/showmarc.pl?viewas=card&id=[% loop_order.biblionumber %]" title="MARC" rel="gb_page_center[600,500]">Card</a> >+ </td> > <td>[% loop_order.quantity %]</td> > <td>[% loop_order.ecost %]</td> > <td>[% loop_order.ordertotal %]</td> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt >new file mode 100644 >index 0000000..6639dd4 >--- /dev/null >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/showorder.tt >@@ -0,0 +1,39 @@ >+[% INCLUDE 'doc-head-open.inc' %] >+<style> >+ td { >+ padding: 0 1em; >+ } >+ td:first-child { >+ font-weight: bold; >+ text-align: right; >+ } >+</style> >+</head> >+<body> >+ [% IF order %] >+ <table> >+ <tbody> >+ <tr> >+ <td>Creation date</td> >+ <td>[% order.entrydate %]</td> >+ </tr> >+ <tr> >+ <td>Creator</td> >+ <td>[% creator.firstname %] [% creator.surname %]</td> >+ </tr> >+ <tr> >+ <td>Claims count</td> >+ <td>[% order.claims_count %]</td> >+ </tr> >+ <tr> >+ <td>Last claim date</td> >+ <td>[% order.claimed_date %]</td> >+ </tr> >+ </tbody> >+ </table> >+ [% ELSE %] >+ No order found. >+ [% END %] >+</body> >+</html> >+ >-- >1.7.10.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12395
:
28754
|
28943
|
30128
|
30129
|
31409
|
31410
|
31411
|
33837
|
33838
|
33839
|
35769
|
35770
|
35771
|
35772
|
35779
|
35780
|
35781
|
35782
|
35864
|
36063
|
36075
|
36076
|
36077
|
36078
|
36079
|
36080
|
40132
|
40133
|
40134
|
40135
|
40136
|
40137
|
40138
|
40139
|
40161
|
43951
|
45387
|
58745
|
58746
|
58747
|
58748
|
58749
|
58750
|
61383
|
61384
|
71344
|
71345
|
71346
|
71347
|
71348
|
71349
|
72720
|
72721
|
72722
|
72723
|
72724
|
72725
|
74207
|
74208
|
74209
|
74210
|
74211
|
74212
|
74276
|
74277
|
74278
|
74279
|
74280
|
74281
|
74282
|
75900
|
75901
|
75902
|
75903
|
75904
|
75905
|
75906
|
75907
|
76074
|
76075
|
76076
|
76077
|
76078
|
76079
|
76080
|
76081
|
76082
|
76083
|
76084
|
76085
|
76086
|
76087
|
76088
|
76089