Bugzilla – Attachment 29026 Details for
Bug 9811
Patrons search improvements
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 9811: Remove useless orderby management
PASSED-QA-Bug-9811-Remove-useless-orderby-manageme.patch (text/plain), 2.22 KB, created by
Katrin Fischer
on 2014-06-19 13:25:33 UTC
(
hide
)
Description:
[PASSED QA] Bug 9811: Remove useless orderby management
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-06-19 13:25:33 UTC
Size:
2.22 KB
patch
obsolete
>From 1dd7be46a836ac261d1cd6312ee20440dee512c4 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 9 Jun 2014 17:35:15 +0200 >Subject: [PATCH] [PASSED QA] Bug 9811: Remove useless orderby management > >I don't know what is this stuff. I didn't find a call to member.pl with >an orderby parameter. >I am not sure this is in used. > >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 6 +++--- > members/member.pl | 6 ------ > 2 files changed, 3 insertions(+), 9 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >index ae7f06f..0d81448 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt >@@ -205,10 +205,10 @@ $(document).ready(function() { > }, > 'bFilter': false, > 'bAutoWidth': false, >- [% IF orderby_cardnumber_0 %] >- 'aaSorting': [[0, 'asc']], >- [% ELSE %] >+ [% IF CAN_user_tools_manage_patron_lists %] > 'aaSorting': [[1, 'asc']], >+ [% ELSE %] >+ 'aaSorting': [[0, 'asc']], > [% END %] > "aLengthMenu": [aLengthMenu, aLengthMenuLabel], > 'sPaginationType': 'full_numbers', >diff --git a/members/member.pl b/members/member.pl >index 9cefc79..cd80577 100755 >--- a/members/member.pl >+++ b/members/member.pl >@@ -108,11 +108,6 @@ if ( $patron->{categorycode} ) { > > $template->param( 'alphabet' => C4::Context->preference('alphabet') || join ' ', 'A' .. 'Z' ); > >-my $orderby = $input->param('orderby') // ''; >-if(defined $orderby and $orderby ne '') { >- $orderby =~ s/[, ]/_/g; >-} >- > my $view = $input->request_method() eq "GET" ? "show_form" : "show_results"; > > $template->param( >@@ -124,7 +119,6 @@ $template->param( > categorycode => $patron->{categorycode}, > searchtype => $input->param('searchtype') || 'start_with', > searchfieldstype => $searchfieldstype, >- "orderby_$orderby" => 1, > PatronsPerPage => C4::Context->preference("PatronsPerPage") || 20, > view => $view, > ); >-- >1.8.3.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 9811
:
16096
|
16111
|
16112
|
16320
|
16362
|
16403
|
16957
|
19056
|
19057
|
19307
|
19633
|
19642
|
20094
|
20095
|
20096
|
20174
|
20266
|
20290
|
20291
|
21169
|
21170
|
21171
|
21172
|
21173
|
21174
|
21175
|
22265
|
23261
|
24095
|
24111
|
26067
|
26068
|
26261
|
26336
|
26337
|
26342
|
26347
|
27642
|
27643
|
27644
|
27645
|
27646
|
27711
|
28738
|
28739
|
28740
|
28741
|
28742
|
28743
|
28744
|
28745
|
28746
|
28747
|
28781
|
28782
|
29019
|
29020
|
29021
|
29022
|
29023
|
29024
|
29025
| 29026 |
29027
|
29028
|
29029
|
29442