From 0067f39b9aebb0e726a872eed16883a78c92d215 Mon Sep 17 00:00:00 2001 From: Kyle M Hall <kyle@bywatersolutions.com> Date: Mon, 23 Jun 2014 12:21:16 -0400 Subject: [PATCH] Bug 12467 - Lost items marked as not on loan even if they are! The cronjob longoverdue.pl does not require that an item marked as lost be returned automatically, but there is a line in ModItem that automatically marks the item's onloan as false if itemlost is set! Test Plan: 1) Mark an item as lost with longoverdue.pl, without --mark-returned 2) Inspect the db, note that items.onloan is now 0 3) Apply this patch 4) Mark repeat step 1 5) Inspect the db, noe that items.onloan is still 1 6) Test marking an item as lost from staff interface, ensure there are no regressions. --- C4/Circulation.pm | 2 ++ C4/Items.pm | 2 -- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Circulation.pm b/C4/Circulation.pm index 6b700ec..ff3fe67 100644 --- a/C4/Circulation.pm +++ b/C4/Circulation.pm @@ -2060,6 +2060,8 @@ sub MarkIssueReturned { WHERE borrowernumber = ? AND itemnumber = ?"); $sth_del->execute($borrowernumber, $itemnumber); + + ModItem( { 'onloan' => undef }, undef, $itemnumber ); } =head2 _debar_user_on_return diff --git a/C4/Items.pm b/C4/Items.pm index c183644..61069e8 100644 --- a/C4/Items.pm +++ b/C4/Items.pm @@ -540,8 +540,6 @@ sub ModItem { $item->{'itemnumber'} = $itemnumber or return; - $item->{onloan} = undef if $item->{itemlost}; - my @fields = qw( itemlost withdrawn ); # Only call GetItem if we need to set an "on" date field -- 1.7.2.5