From fb443b24d14d92a0fc8d11c821b9d0f317447d05 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@biblibre.com>
Date: Mon, 10 Mar 2014 11:58:33 +0100
Subject: [PATCH] Bug 7677: FIX QA issues

 FAIL    C4/Serials.pm
   FAIL      forbidden patterns
    forbidden pattern: trailing space char (line 1501)
    forbidden pattern: trailing space char (line 921)

 FAIL    serials/serials-edit.pl
   FAIL      valid
        "my" variable $dbh masks earlier declaration in same scope
---
 C4/Serials.pm           | 4 ++--
 serials/serials-edit.pl | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/C4/Serials.pm b/C4/Serials.pm
index b765904..4f3981f 100644
--- a/C4/Serials.pm
+++ b/C4/Serials.pm
@@ -916,7 +916,7 @@ sub GetPreviousSerialid {
                         FROM     serial
                         WHERE    subscriptionid = ?
                         AND      status = 2
-                        ORDER BY serialid DESC LIMIT $nth,1 
+                        ORDER BY serialid DESC LIMIT $nth,1
                 ";
     my $sth = $dbh->prepare($strsth);
     $sth->execute($subscriptionid);
@@ -1463,7 +1463,7 @@ $subscriptionid = &NewSubscription($auser,branchcode,$aqbooksellerid,$cost,$aqbu
     $lastvalue1,$innerloop1,$lastvalue2,$innerloop2,$lastvalue3,$innerloop3,
     $status, $notes, $letter, $firstacquidate, $irregularity, $numberpattern,
     $locale, $callnumber, $manualhistory, $internalnotes, $serialsadditems,
-    $staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate, 
+    $staffdisplaycount, $opacdisplaycount, $graceperiod, $location, $enddate,
     $skip_serialseq, $itemtype, $previousitemtype);
 
 Create a new subscription with value given on input args.
diff --git a/serials/serials-edit.pl b/serials/serials-edit.pl
index c49adb2..a1408fa 100755
--- a/serials/serials-edit.pl
+++ b/serials/serials-edit.pl
@@ -90,7 +90,6 @@ if ( scalar(@subscriptionids) == 1 && index( $subscriptionids[0], q|,| ) > 0 ) {
 }
 my @errors;
 my @errseq;
-my $dbh   = C4::Context->dbh;
 
 # If user comes from subscription details
 unless (@serialids) {
-- 
2.0.0.rc2