Bugzilla – Attachment 2981 Details for
Bug 4438
incorrect "Budget total exceeds period allocation" error when editing fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
fix the ajax calculation
0001-Bug-4438-incorrect-Budget-total-exceeds-period-alloc.patch (text/plain), 1.47 KB, created by
dev_patches
on 2011-01-13 10:58:30 UTC
(
hide
)
Description:
fix the ajax calculation
Filename:
MIME Type:
Creator:
dev_patches
Created:
2011-01-13 10:58:30 UTC
Size:
1.47 KB
patch
obsolete
>From: Henri-Damien LAURENT <henridamien.laurent@biblibre.com> >Date: Thu, 13 Jan 2011 10:59:10 +0100 >Subject: [PATCH] Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund > >The process in check_parent_total for period allocation was not good. >It took all the children of a period. > >Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com> >--- > admin/check_parent_total.pl | 6 ++---- > 1 files changed, 2 insertions(+), 4 deletions(-) > >diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl >index c5630e0..cb62f0d 100755 >--- a/admin/check_parent_total.pl >+++ b/admin/check_parent_total.pl >@@ -25,7 +25,6 @@ use C4::Context; > use C4::Output; > use C4::Auth; > use C4::Budgets; >- > =head1 > > This script checks the amount unallocated from the new parent budget , or the period - if no parent_id is given >@@ -76,7 +75,7 @@ if ($parent) { > # ELSE , IF NO PARENT PASSED, THEN CHECK UNALLOCATED FOR PERIOD, IF NOT THEN RETURN 2 > else { > my $query = qq| SELECT SUM(budget_amount) as sum >- FROM aqbudgets WHERE budget_period_id = ?|; >+ FROM aqbudgets WHERE budget_period_id = ? and budget_parent_id IS NULL|; > > my $sth = $dbh->prepare($query); > $sth->execute($period_id); >@@ -96,7 +95,6 @@ if ($parent_id) { > $returncode = 0; > } > >-$template->param( return => $returncode ); > >-output_html_with_http_headers $input, $cookie, $template->output; >+output_html_with_http_headers $input, $cookie, $returncode; > 1; >-- >1.7.0.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4438
:
2981
|
2982
|
2983
|
3184