Bugzilla – Attachment 2983 Details for
Bug 4438
incorrect "Budget total exceeds period allocation" error when editing fund
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
patch appliable for master
0001-Bug-4438-incorrect-Budget-total-exceeds-period-alloc.patch (text/plain), 1.28 KB, created by
dev_patches
on 2011-01-13 12:12:45 UTC
(
hide
)
Description:
patch appliable for master
Filename:
MIME Type:
Creator:
dev_patches
Created:
2011-01-13 12:12:45 UTC
Size:
1.28 KB
patch
obsolete
>From 9819a2c976434f003ca5bd310d72a92fb9cfc446 Mon Sep 17 00:00:00 2001 >From: Henri-Damien LAURENT <henridamien.laurent@biblibre.com> >Date: Thu, 13 Jan 2011 13:09:29 +0100 >Subject: [PATCH] Bug 4438: incorrect "Budget total exceeds period allocation" error when editing fund > >The process in check_parent_total for period allocation was not good. >It took all the children of a period. >--- > admin/check_parent_total.pl | 5 ++--- > 1 files changed, 2 insertions(+), 3 deletions(-) > >diff --git a/admin/check_parent_total.pl b/admin/check_parent_total.pl >index f5d5000..d5b784d 100755 >--- a/admin/check_parent_total.pl >+++ b/admin/check_parent_total.pl >@@ -75,7 +75,7 @@ if ($parent) { > # ELSE , IF NO PARENT PASSED, THEN CHECK UNALLOCATED FOR PERIOD, IF NOT THEN RETURN 2 > else { > my $query = qq| SELECT SUM(budget_amount) as sum >- FROM aqbudgets WHERE budget_period_id = ?|; >+ FROM aqbudgets WHERE budget_period_id = ? and budget_parent_id IS NULL|; > > my $sth = $dbh->prepare($query); > $sth->execute( $period_id ); >@@ -95,7 +95,6 @@ if ( $parent_id) { > $returncode = 0; > } > >-$template->param( return => $returncode ); > >-output_html_with_http_headers $input, $cookie, $template->output; >+output_html_with_http_headers $input, $cookie, $returncode; > 1; >-- >1.7.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4438
:
2981
|
2982
| 2983 |
3184