Bugzilla – Attachment 30046 Details for
Bug 12445
C4::Suggestions.pm needs more unit tests
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus
SIGNED-OFF-Bug-12445-ading-unit-tests-to-test-the-.patch (text/plain), 14.11 KB, created by
Bernardo Gonzalez Kriegel
on 2014-07-24 18:58:06 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 12445: ading unit tests to test the routines : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus
Filename:
MIME Type:
Creator:
Bernardo Gonzalez Kriegel
Created:
2014-07-24 18:58:06 UTC
Size:
14.11 KB
patch
obsolete
>From 33b28a3e70f12373ce2e6d88c6c77e4f659c952c Mon Sep 17 00:00:00 2001 >From: Yohann Dufour <dufour.yohann@gmail.com> >Date: Thu, 19 Jun 2014 16:32:05 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 12445: ading unit tests to test the routines > : CountSuggestion, ConnectSuggestionAndBiblio, SearchSuggestion, > GetSuggestionInfo, DelSuggestion, GetSuggestionByStatus > >These routines were not tested > >Test plan: >1/ Execute the command : prove t/db_dependent/Suggestions.t >2/ The result has to be a success without error or warning : >t/db_dependent/Suggestions.t .. ok >All tests successful. >Files=1, Tests=89, 1 wallclock secs ( 0.05 usr 0.01 sys + 1.52 cusr 0.08 csys = 1.66 CPU) >Result: PASS > >Signed-off-by: Paola Rossi <paola.rossi@cineca.it> >Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> >Test pass, no koha-qa errors > >But now there are 91! >prove t/db_dependent/Suggestions.t >t/db_dependent/Suggestions.t .. ok >All tests successful. >Files=1, Tests=91, 2 wallclock secs ( 0.05 usr 0.00 sys + 1.77 cusr 0.10 csys = 1.92 CPU) >Result: PASS >--- > t/db_dependent/Suggestions.t | 163 ++++++++++++++++++++++++++++++++++++------- > 1 file changed, 137 insertions(+), 26 deletions(-) > >diff --git a/t/db_dependent/Suggestions.t b/t/db_dependent/Suggestions.t >index cb2fd5b..37261eb 100644 >--- a/t/db_dependent/Suggestions.t >+++ b/t/db_dependent/Suggestions.t >@@ -17,12 +17,11 @@ > > use Modern::Perl; > >-use C4::Suggestions; > use C4::Context; > use C4::Members; > use C4::Letters; > >-use Test::More tests => 34; >+use Test::More tests => 91; > use Test::Warn; > > BEGIN { >@@ -42,22 +41,35 @@ $dbh->do(q|DELETE FROM letter|); > $dbh->do(q|DELETE FROM message_queue|); > $dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|); > >-my $borrowernumber = AddMember( >- firstname => 'my firstname', >- surname => 'my surname', >+my $member = { >+ firstname => 'my firstname', >+ surname => 'my surname', > categorycode => 'S', >- branchcode => 'CPL', >-); >+ branchcode => 'CPL', >+}; >+my $borrowernumber = AddMember(%$member); > >+my $biblionumber1 = 1; > my $my_suggestion = { > title => 'my title', > author => 'my author', > publishercode => 'my publishercode', > suggestedby => $borrowernumber, >- biblionumber => 1, >+ biblionumber => $biblionumber1, > }; >+ >+ >+is( CountSuggestion(), 0, 'CountSuggestion without the status returns 0' ); >+is( CountSuggestion('ASKED'), 0, 'CountSuggestion returns the correct number of suggestions' ); >+is( CountSuggestion('CHECKED'), 0, 'CountSuggestion returns the correct number of suggestions' ); >+is( CountSuggestion('ACCEPTED'), 0, 'CountSuggestion returns the correct number of suggestions' ); >+is( CountSuggestion('REJECTED'), 0, 'CountSuggestion returns the correct number of suggestions' ); >+ >+ > my $my_suggestionid = NewSuggestion($my_suggestion); > isnt( $my_suggestionid, 0, 'NewSuggestion returns an not null id' ); >+ >+is( GetSuggestion(), undef, 'GetSuggestion without the suggestion id returns undef' ); > my $suggestion = GetSuggestion($my_suggestionid); > is( $suggestion->{title}, $my_suggestion->{title}, 'NewSuggestion stores the title correctly' ); > is( $suggestion->{author}, $my_suggestion->{author}, 'NewSuggestion stores the author correctly' ); >@@ -65,19 +77,17 @@ is( $suggestion->{publishercode}, $my_suggestion->{publishercode}, 'NewSuggestio > is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'NewSuggestion stores the borrower number correctly' ); > is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'NewSuggestion stores the biblio number correctly' ); > is( $suggestion->{STATUS}, 'ASKED', 'NewSuggestion stores a suggestion with the status ASKED by default' ); >-$suggestion = GetSuggestion(); >-is( $suggestion, undef, 'GetSuggestion without the suggestion id returns undef' ); > >+is( CountSuggestion('ASKED'), 1, 'CountSuggestion returns the correct number of suggestions' ); > >-my $status = ModSuggestion(); >-is( $status, undef, 'ModSuggestion without arguments returns undef' ); > >+is( ModSuggestion(), undef, 'ModSuggestion without the suggestion returns undef' ); > my $mod_suggestion1 = { > title => 'my modified title', > author => 'my modified author', > publishercode => 'my modified publishercode', > }; >-$status = ModSuggestion($mod_suggestion1); >+my $status = ModSuggestion($mod_suggestion1); > is( $status, '0E0', 'ModSuggestion without the suggestion id returns 0E0' ); > > $mod_suggestion1->{suggestionid} = $my_suggestionid; >@@ -115,26 +125,127 @@ $messages = C4::Letters::GetQueuedMessages({ > }); > is( @$messages, 1, 'ModSuggestion sends an email if the status is updated' ); > >-my $biblionumber = 1; >-my $suggestionid = GetSuggestionFromBiblionumber($biblionumber); >-is( $suggestionid, $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' ); >+is( CountSuggestion('CHECKED'), 1, 'CountSuggestion returns the correct number of suggestions' ); >+ >+ >+is( GetSuggestionInfo(), undef, 'GetSuggestionInfo without the suggestion id returns undef' ); >+$suggestion = GetSuggestionInfo($my_suggestionid); >+is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfo returns the suggestion id correctly' ); >+is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfo returns the title correctly' ); >+is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfo returns the author correctly' ); >+is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfo returns the publisher code correctly' ); >+is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' ); >+is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfo returns the biblio number correctly' ); >+is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfo returns the status correctly' ); >+is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfo returns the surname correctly' ); >+is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfo returns the firstname correctly' ); >+is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfo returns the borrower number correctly' ); >+ >+ >+is( GetSuggestionFromBiblionumber(), undef, 'GetSuggestionFromBiblionumber without the biblio number returns undef' ); >+is( GetSuggestionFromBiblionumber(2), undef, 'GetSuggestionFromBiblionumber with an invalid biblio number returns undef' ); >+is( GetSuggestionFromBiblionumber($biblionumber1), $my_suggestionid, 'GetSuggestionFromBiblionumber functions correctly' ); >+ >+ >+is( GetSuggestionInfoFromBiblionumber(), undef, 'GetSuggestionInfoFromBiblionumber without the biblio number returns undef' ); >+is( GetSuggestionInfoFromBiblionumber(2), undef, 'GetSuggestionInfoFromBiblionumber with an invalid biblio number returns undef' ); >+$suggestion = GetSuggestionInfoFromBiblionumber($biblionumber1); >+is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber returns the suggestion id correctly' ); >+is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber returns the title correctly' ); >+is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber returns the author correctly' ); >+is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber returns the publisher code correctly' ); >+is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber returns the borrower number correctly' ); >+is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber returns the biblio number correctly' ); >+is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber returns the status correctly' ); >+is( $suggestion->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionInfoFromBiblionumber returns the surname correctly' ); >+is( $suggestion->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionInfoFromBiblionumber returns the firstname correctly' ); >+is( $suggestion->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumeber returns the borrower number correctly' ); >+ >+ >+my $suggestions = GetSuggestionByStatus(); >+is( @$suggestions, 0, 'GetSuggestionByStatus without the status returns an empty array' ); >+$suggestions = GetSuggestionByStatus('CHECKED'); >+is( @$suggestions, 1, 'GetSuggestionByStatus returns the correct number of suggestions' ); >+is( $suggestions->[0]->{suggestionid}, $my_suggestionid, 'GetSuggestionByStatus returns the suggestion id correctly' ); >+is( $suggestions->[0]->{title}, $mod_suggestion1->{title}, 'GetSuggestionByStatus returns the title correctly' ); >+is( $suggestions->[0]->{author}, $mod_suggestion1->{author}, 'GetSuggestionByStatus returns the author correctly' ); >+is( $suggestions->[0]->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionByStatus returns the publisher code correctly' ); >+is( $suggestions->[0]->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' ); >+is( $suggestions->[0]->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionByStatus returns the biblio number correctly' ); >+is( $suggestions->[0]->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionByStatus returns the status correctly' ); >+is( $suggestions->[0]->{surnamesuggestedby}, $member->{surname}, 'GetSuggestionByStatus returns the surname correctly' ); >+is( $suggestions->[0]->{firstnamesuggestedby}, $member->{firstname}, 'GetSuggestionByStatus returns the firstname correctly' ); >+is( $suggestions->[0]->{branchcodesuggestedby}, $member->{branchcode}, 'GetSuggestionByStatus returns the branch code correctly' ); >+is( $suggestions->[0]->{borrnumsuggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionByStatus returns the borrower number correctly' ); >+is( $suggestions->[0]->{categorycodesuggestedby}, $member->{categorycode}, 'GetSuggestionByStatus returns the category code correctly' ); >+ >+ >+is( ConnectSuggestionAndBiblio(), '0E0', 'ConnectSuggestionAndBiblio without arguments returns 0E0' ); >+my $biblionumber2 = 2; >+my $connect_suggestion_and_biblio = ConnectSuggestionAndBiblio($my_suggestionid, $biblionumber2); >+is( $connect_suggestion_and_biblio, '1', 'ConnectSuggestionAndBiblio returns 1' ); >+$suggestion = GetSuggestion($my_suggestionid); >+is( $suggestion->{biblionumber}, $biblionumber2, 'ConnectSuggestionAndBiblio updates the biblio number correctly' ); > > >-$suggestion = GetSuggestionInfoFromBiblionumber($biblionumber); >-is( $suggestion->{suggestionid}, $my_suggestionid, 'GetSuggestionInfoFromBiblionumber gets the suggestion id correctly' ); >+my $search_suggestion = SearchSuggestion(); >+is( @$search_suggestion, 1, 'SearchSuggestion without arguments returns all suggestions' ); >+ >+$search_suggestion = SearchSuggestion({ >+ title => $mod_suggestion1->{title}, >+}); >+is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' ); >+$search_suggestion = SearchSuggestion({ >+ title => 'another title', >+}); >+is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' ); > >-is( $suggestion->{title}, $mod_suggestion1->{title}, 'GetSuggestionInfoFromBiblionumber gets the title correctly' ); >-is( $suggestion->{author}, $mod_suggestion1->{author}, 'GetSuggestionInfoFromBiblionumber gets the author correctly' ); >-is( $suggestion->{publishercode}, $mod_suggestion1->{publishercode}, 'GetSuggestionInfoFromBiblionumber gets the publisher code correctly' ); >-is( $suggestion->{suggestedby}, $my_suggestion->{suggestedby}, 'GetSuggestionInfoFromBiblionumber gets the borrower number correctly' ); >-is( $suggestion->{biblionumber}, $my_suggestion->{biblionumber}, 'GetSuggestionInfoFromBiblionumber gets the biblio number correctly' ); >-is( $suggestion->{STATUS}, $mod_suggestion3->{STATUS}, 'GetSuggestionInfoFromBiblionumber gets the status correctly' ); >+$search_suggestion = SearchSuggestion({ >+ author => $mod_suggestion1->{author}, >+}); >+is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' ); >+$search_suggestion = SearchSuggestion({ >+ author => 'another author', >+}); >+is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' ); > >+$search_suggestion = SearchSuggestion({ >+ publishercode => $mod_suggestion3->{publishercode}, >+}); >+is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' ); >+$search_suggestion = SearchSuggestion({ >+ publishercode => 'another publishercode', >+}); >+is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' ); > >-my $search_suggestion = SearchSuggestion({ >+$search_suggestion = SearchSuggestion({ > STATUS => $mod_suggestion3->{STATUS}, > }); >-is( @$search_suggestion, 1, '' ); >+is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' ); >+$search_suggestion = SearchSuggestion({ >+ STATUS => 'REJECTED', >+}); >+is( @$search_suggestion, 0, 'SearchSuggestion returns the correct number of suggestions' ); >+ >+ >+my $del_suggestion = { >+ title => 'my deleted title', >+ STATUS => 'CHECKED', >+ suggestedby => $borrowernumber, >+}; >+my $del_suggestionid = NewSuggestion($del_suggestion); >+ >+is( CountSuggestion('CHECKED'), 2, 'CountSuggestion returns the correct number of suggestions' ); >+ >+is( DelSuggestion(), '0E0', 'DelSuggestion without arguments returns 0E0' ); >+is( DelSuggestion($borrowernumber), '', 'DelSuggestion without the suggestion id returns an empty string' ); >+is( DelSuggestion(undef, $my_suggestionid), '', 'DelSuggestion with an invalid borrower number returns an empty string' ); >+$suggestion = DelSuggestion($borrowernumber, $my_suggestionid); >+is( $suggestion, 1, 'DelSuggestion deletes one suggestion' ); >+ >+$suggestions = GetSuggestionByStatus('CHECKED'); >+is( @$suggestions, 1, 'DelSuggestion deletes one suggestion' ); >+is( $suggestions->[0]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' ); > > ## Bug 11466, making sure GetSupportList() returns itemtypes, even if AdvancedSearchTypes has multiple values > C4::Context->set_preference("AdvancedSearchTypes", 'itemtypes|loc|ccode'); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12445
:
28973
|
29041
|
29103
|
29104
|
29954
|
29955
|
30045
|
30046
|
30094
|
30096
|
30097
|
30098
|
30166
|
30167
|
30168