Bugzilla – Attachment 30179 Details for
Bug 12642
SMS.t requires a database
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12642: t/SMS.t should not be db dependent
PASSED-QA-Bug-12642-tSMSt-should-not-be-db-depende.patch (text/plain), 1.05 KB, created by
Katrin Fischer
on 2014-07-28 06:01:02 UTC
(
hide
)
Description:
[PASSED QA] Bug 12642: t/SMS.t should not be db dependent
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-07-28 06:01:02 UTC
Size:
1.05 KB
patch
obsolete
>From 2b2d3e66b026fbb73e2a407c30e5763ac966d316 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 25 Jul 2014 10:59:11 +0200 >Subject: [PATCH] [PASSED QA] Bug 12642: t/SMS.t should not be db dependent > >SMS.t should not dependent on the DB. > >Test plan: >verify that prove t/SMS.t returns green even if the DB is not there. > >Signed-off-by: Robin Sheat <robin@catalyst.net.nz> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Turned off MySQL, tests still pass. >--- > t/SMS.t | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/t/SMS.t b/t/SMS.t >index 9901858..fca44b4 100755 >--- a/t/SMS.t >+++ b/t/SMS.t >@@ -30,6 +30,8 @@ my $driver = 'my mock driver'; > t::lib::Mocks::mock_preference('SMSSendDriver', $driver); > is( C4::SMS->driver(), $driver, 'driver returns the SMSSendDriver correctly' ); > >+t::lib::Mocks::mock_preference('SMSSendUsername', 'username'); >+t::lib::Mocks::mock_preference('SMSSendPassword', 'pwd'); > > my $send_sms = C4::SMS->send_sms(); > is( $send_sms, undef, 'send_sms without arguments returns undef' ); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12642
:
30010
|
30076
|
30177
| 30179 |
33969