From 42498c30b22047ea4c03127a43eb8116cdaeabf8 Mon Sep 17 00:00:00 2001 From: Yohann Dufour Date: Fri, 20 Jun 2014 14:31:53 +0200 Subject: [PATCH] [PASSED QA] Bug 12457: Removal warning in t/db_dependent/Members.t When I execute prove t/db_dependent/Members.t, this warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." The warning is due to a invalid use of the routine set_userenv Test plan: 1/ Execute : prove t/db_dependent/Members.t 2/ The warning appears twice : "Argument "Test" isn't numeric in modulus (%) at /home/yohann/koha/C4/Context.pm line 1256." 3/ Apply the patch 4/ Execute : prove t/db_dependent/Members.t 5/ The result has to be a success without error or warning : t/db_dependent/Members.t .. ok All tests successful. Files=1, Tests=26, 2 wallclock secs ( 0.04 usr 0.01 sys + 1.50 cusr 0.08 csys = 1.63 CPU) Result: PASS Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer All new and old tests pass now. --- t/db_dependent/Members.t | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/t/db_dependent/Members.t b/t/db_dependent/Members.t index 7bbf1ca..340a6c9 100755 --- a/t/db_dependent/Members.t +++ b/t/db_dependent/Members.t @@ -61,10 +61,10 @@ my @USERENV = ( 'Test', 0, ); -my $BRANCH_IDX = 4; +my $BRANCH_IDX = 5; C4::Context->_new_userenv ('DUMMY_SESSION_ID'); -C4::Context->set_userenv ( @USERENV ); +C4::Context::set_userenv ( @USERENV ); my $userenv = C4::Context->userenv or BAIL_OUT("No userenv"); @@ -155,7 +155,7 @@ ok (!_find_member($results), "Search (arrayref) for independent branches, differ or diag("Card $CARDNUMBER found in the resultset for independent branches: ".Dumper(C4::Context->preference($INDEPENDENT_BRANCHES_PREF), $results)); $USERENV[$BRANCH_IDX] = $BRANCHCODE; -C4::Context->set_userenv ( @USERENV ); +C4::Context::set_userenv ( @USERENV ); $results = Search("$CHANGED_FIRSTNAME $SURNAME", "surname"); ok (_find_member($results), "Full name Search (string) for independent branches, same branch") -- 1.9.1