Bugzilla – Attachment 30348 Details for
Bug 12528
Enable staff to deny message setting access to patrons on the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC
Bug-12528---Enable-staff-to-deny-message-setting-a.patch (text/plain), 3.73 KB, created by
simith.doliveira
on 2014-07-30 15:11:35 UTC
(
hide
)
Description:
Bug 12528 - Enable staff to deny message setting access to patrons on the OPAC
Filename:
MIME Type:
Creator:
simith.doliveira
Created:
2014-07-30 15:11:35 UTC
Size:
3.73 KB
patch
obsolete
>From e07b28ad49e006c1da1b33fba8c14e0a1011ff67 Mon Sep 17 00:00:00 2001 >From: simith <simith@inlibro.com> >Date: Wed, 30 Jul 2014 10:56:43 -0400 >Subject: [PATCH] Bug 12528 - Enable staff to deny message setting access to > patrons on the OPAC > > This fix permits the staff to pull apart the access to patron message setting. > > Modified: > > installer/data/mysql/sysprefs.sql -OPACEnhancedMessagingPreferences preference added > koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/patrons.pref -OPACEnhancedMessagingPreferences preference added > koha-tmpl/opac-tmpl/bootstrap/en/includes/usermenu.inc -access to message setting changed > > Testing: > > I Apply the patch > II Run updatedatabase.pl > > 0) Search OPACEnhancedMessagingPreferences preference; > 1) Validate "OPACEnhancedMessagingPreferences show patron messaging setting on the OPAC (NOTE: EnhancedMessagingPreferences must be enabled)."; > 2) Disable OPACEnhancedMessagingPreferences preference; > 3) Enable EnhancedMessagingPreferences preference; > 4) On the OPAC -> user's settings, validate "your messaging" is not showed. >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt | 8 ++++++-- > opac/opac-messaging.pl | 4 +++- > 2 files changed, 9 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >index 21c40c7..881d8d3 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-messaging.tt >@@ -5,7 +5,6 @@ > </head> > <body id="opac-messaging"> > [% INCLUDE 'masthead.inc' %] >- > <div class="main"> > <ul class="breadcrumb"> > <li><a href="/cgi-bin/koha/opac-main.pl">Home</a> <span class="divider">›</span></li> >@@ -21,6 +20,7 @@ > </div> > </div> > <div class="span10"> >+ [% IF (Authorized) %] > <div id="usermessaging"> > <h3>Your messaging settings</h3> > [% IF ( settings_updated ) %] >@@ -120,6 +120,10 @@ > </fieldset> > </form> > </div> <!-- / #usermessaging --> >+ [% ELSE %] >+ <h4>You are not allowed to call this page directly</h4> >+ <span> To report this problem, you can <a href="mailto:[% admin %]">email the Koha Administrator</a>.</span> >+ [% END %] > </div> <!-- / .span10 --> > </div> <!-- / .row-fluid --> > </div> <!-- / .container-fluid --> >@@ -142,4 +146,4 @@ > }); > //]]> > </script> >-[% END %] >+[% END %] >\ No newline at end of file >diff --git a/opac/opac-messaging.pl b/opac/opac-messaging.pl >index 096dbff..74d95ef 100755 >--- a/opac/opac-messaging.pl >+++ b/opac/opac-messaging.pl >@@ -68,6 +68,8 @@ $template->param( BORROWER_INFO => [ $borrower ], > messagingview => 1, > SMSnumber => defined $borrower->{'smsalertnumber'} ? $borrower->{'smsalertnumber'} : $borrower->{'mobile'}, > SMSSendDriver => C4::Context->preference("SMSSendDriver"), >- TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification") ); >+ TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification"), >+ admin => C4::Context->preference('KohaAdminEmailAddress'), >+ Authorized => C4::Context->preference('OPACEnhancedMessagingPreferences')); > > output_html_with_http_headers $query, $cookie, $template->output; >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12528
:
29505
|
30259
|
30348
|
30349
|
30487
|
31047
|
36511
|
36512
|
36513
|
36818
|
44302
|
44820
|
44826
|
45885
|
45886
|
45962
|
46003
|
46015
|
46082
|
46156
|
46217
|
46218
|
50649
|
50650
|
50651
|
50652
|
50988
|
50989
|
51000
|
51001
|
51002
|
51003
|
51004