Bugzilla – Attachment 30390 Details for
Bug 8995
Show OpenURL links in OPAC search results
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links
Bug-8995-Consider-OPACURLOpenInNewWindow-for-OpenU.patch (text/plain), 6.45 KB, created by
Julian Maurice
on 2014-07-31 10:07:58 UTC
(
hide
)
Description:
Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2014-07-31 10:07:58 UTC
Size:
6.45 KB
patch
obsolete
>From 6f917ceed788937a88a929c1c11cb63977cb8864 Mon Sep 17 00:00:00 2001 >From: Julian Maurice <julian.maurice@biblibre.com> >Date: Thu, 31 Jul 2014 12:06:16 +0200 >Subject: [PATCH] Bug 8995: Consider OPACURLOpenInNewWindow for OpenURL links > >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++++- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt | 6 +++++- > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl | 5 +++++ > koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 5 +++++ > koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl | 5 +++++ > .../opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl | 5 +++++ > 6 files changed, 30 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index e7855ce..f970bde 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -353,7 +353,11 @@ > [% END %] > > <span class="results_summary"> >- <a class="OpenURL" href="[% OpenURLResolverURL %]?[% ocoins %]" title="[% OpenURLText %]"> >+ [% OpenURLTarget = '_self' %] >+ [% IF ( OPACURLOpenInNewWindow ) %] >+ [% OpenURLTarget = '_blank' %] >+ [% END %] >+ <a class="OpenURL" href="[% OpenURLResolverURL %]?[% ocoins %]" title="[% OpenURLText %]" target="[% OpenURLTarget %]"> > [% IF openurlimagelocation %] > <img src="[% openurlimagelocation %]" /> > [% ELSIF OpenURLText %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >index 2789493..3b82c1b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-results.tt >@@ -173,6 +173,10 @@ > [% ELSE %] > [% openurlimagelocation = "$OpenURLImageLocation" %] > [% END %] >+ [% OpenURLTarget = '_self' %] >+ [% IF ( OPACURLOpenInNewWindow ) %] >+ [% OpenURLTarget = '_blank' %] >+ [% END %] > > <!-- Actual Search Results --> > [% FOREACH SEARCH_RESULT IN SEARCH_RESULTS %] >@@ -325,7 +329,7 @@ > > [% END %] > [% IF (SEARCH_RESULT.ShowOpenURL && OpenURLResolverURL && SEARCH_RESULT.coins) %] >- <a class="OpenURL" href="[% OpenURLResolverURL %]?[% SEARCH_RESULT.coins %]" title="[% OpenURLText %]"> >+ <a class="OpenURL" href="[% OpenURLResolverURL %]?[% SEARCH_RESULT.coins %]" title="[% OpenURLText %]" target="[% OpenURLTarget %]"> > [% IF openurlimagelocation %] > <img src="[% openurlimagelocation %]" /> > [% ELSIF OpenURLText %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >index ea19f58..ae19e5e 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACDetail.xsl >@@ -1024,6 +1024,11 @@ > <xsl:attribute name="class"> > <xsl:text>OpenURL</xsl:text> > </xsl:attribute> >+ <xsl:if test="$OPACURLOpenInNewWindow='1'"> >+ <xsl:attribute name="target"> >+ <xsl:text>_blank</xsl:text> >+ </xsl:attribute> >+ </xsl:if> > <xsl:choose> > <xsl:when test="$openurlimagelocation != ''"> > <img> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index 67b0d30..c42b71b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -481,6 +481,11 @@ > <xsl:attribute name="class"> > <xsl:text>OpenURL</xsl:text> > </xsl:attribute> >+ <xsl:if test="$OPACURLOpenInNewWindow='1'"> >+ <xsl:attribute name="target"> >+ <xsl:text>_blank</xsl:text> >+ </xsl:attribute> >+ </xsl:if> > <xsl:choose> > <xsl:when test="$openurlimagelocation != ''"> > <img> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl >index b07abb0..781f22b 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACDetail.xsl >@@ -481,6 +481,11 @@ > <xsl:attribute name="class"> > <xsl:text>OpenURL</xsl:text> > </xsl:attribute> >+ <xsl:if test="$OPACURLOpenInNewWindow='1'"> >+ <xsl:attribute name="target"> >+ <xsl:text>_blank</xsl:text> >+ </xsl:attribute> >+ </xsl:if> > <xsl:choose> > <xsl:when test="$openurlimagelocation != ''"> > <img> >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl >index 4956b27..544dce7 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslim2OPACResults.xsl >@@ -119,6 +119,11 @@ > <xsl:attribute name="class"> > <xsl:text>OpenURL</xsl:text> > </xsl:attribute> >+ <xsl:if test="$OPACURLOpenInNewWindow='1'"> >+ <xsl:attribute name="target"> >+ <xsl:text>_blank</xsl:text> >+ </xsl:attribute> >+ </xsl:if> > <xsl:choose> > <xsl:when test="$openurlimagelocation != ''"> > <img> >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8995
:
13141
|
22753
|
23625
|
23626
|
23627
|
24087
|
24088
|
24089
|
26899
|
26900
|
26901
|
29357
|
29358
|
29359
|
30385
|
30386
|
30387
|
30388
|
30389
|
30390
|
35747
|
35916
|
40647
|
44639
|
48371
|
48372
|
55131
|
55132
|
55133
|
55134
|
55135
|
55136
|
55882
|
64513
|
64514
|
64515
|
64516
|
64517
|
64518
|
64519
|
64532
|
64533
|
64534
|
64535
|
64536
|
64537
|
64538
|
86483
|
86484
|
86485
|
86486
|
86487
|
86488
|
86489
|
86490
|
86491
|
86492
|
86541
|
86542
|
86557
|
86558
|
86559
|
86601
|
86602
|
86603
|
86604
|
86605
|
86606
|
86607
|
86608
|
86609
|
86610
|
88665
|
88666
|
88667
|
88668
|
88669
|
88670
|
88671
|
88672
|
88673
|
88735
|
88736
|
88737
|
88738
|
88739
|
88740
|
88741
|
88742
|
88743
|
88744
|
89012
|
89013
|
89014
|
89015
|
89120