From a9f9171be22c580412a62e4df1814f7e6e64ae63 Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Fri, 1 Aug 2014 22:49:35 -0300 Subject: [PATCH] [SIGNED-OFF] Bug 12695: Remove CGI::scrolling_list from marc21_linking_section.pl Content-Type: text/plain; charset="utf-8" Same situation as Bug 12694. There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on marc21_linking_section.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. Can't remember how to trigger this plugin. You can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Owen Leonard Followed test plan successfully. The behavior of the plugin window appears to be unchanged after applying the patch. --- .../value_builder/marc21_linking_section.pl | 59 ++------------------ 1 file changed, 5 insertions(+), 54 deletions(-) diff --git a/cataloguing/value_builder/marc21_linking_section.pl b/cataloguing/value_builder/marc21_linking_section.pl index 514394f..baf0490 100644 --- a/cataloguing/value_builder/marc21_linking_section.pl +++ b/cataloguing/value_builder/marc21_linking_section.pl @@ -335,62 +335,13 @@ sub plugin { } ); - my $sth = $dbh->prepare( - "Select itemtype,description from itemtypes order by description"); - $sth->execute; - my @itemtype; - my %itemtypes; - push @itemtype, ""; - $itemtypes{''} = ""; - while ( my ( $value, $lib ) = $sth->fetchrow_array ) { - push @itemtype, $value; - $itemtypes{$value} = $lib; - } + my @itemtypes = C4::ItemType->all; - my $CGIitemtype = CGI::scrolling_list( - -name => 'value', - -values => \@itemtype, - -labels => \%itemtypes, - -size => 1, - -multiple => 0 - ); - $sth->finish; - - # To show list of branches please use GetBranchesLoop() and modify template - - my $req = $dbh->prepare( -"select distinctrow left(publishercode,45) from biblioitems order by publishercode" - ); - $req->execute; - my @select; - push @select, ""; - while ( my ($value) = $req->fetchrow ) { - push @select, $value; - } - my $CGIpublisher = CGI::scrolling_list( - -name => 'value', - -id => 'publisher', - -values => \@select, - -size => 1, - -multiple => 0 - ); - -# my $sth=$dbh->prepare("select description,itemtype from itemtypes order by description"); -# $sth->execute; -# while (my ($description,$itemtype) = $sth->fetchrow) { -# $classlist.="\n"; -# } -# $sth->finish; - - my @itemtypes = C4::ItemType->all; - - $template->param( #classlist => $classlist, - CGIitemtype => $CGIitemtype, - CGIPublisher => $CGIpublisher, - itypeloop => \@itemtypes, - index => $query->param('index'), + $template->param( + itypeloop => \@itemtypes, + index => $query->param('index'), Search => 1, - ); + ); } output_html_with_http_headers $query, $cookie, $template->output; } -- 1.7.9.5