From 1c52d8cb749c2a0792da0648f8f973ca842fadab Mon Sep 17 00:00:00 2001
From: Mark Tompsett <mtompset@hotmail.com>
Date: Sun, 27 Jul 2014 21:01:29 -0400
Subject: [PATCH] [PASSED QA] Bug 12167: Invalid results check for opac_news
 test

C4/NewsChannels.pm has a function GetNewsToDisplay at the end
of the file. It returns an array reference (i.e. one result).
t/db_dependent/NewsChannels.t has a test which expects two
values. This is likely a cut and paste error on my part.
Notice get_opac_news returns an array of two things.

TEST PLAN
---------
1) prove -v t/db_dependent/NewsChannels.t
   -- magically the wrong condition still passes.
2) apply this first patch only.
3) prove -v t/db_dependent/NewsChannels.t
   -- notice the second result value is UNDEFINED.
   -- notice the first result is an array reference.
   -- and the last test passes, because unless somehow the
      array reference was less than 2, it will pass.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested news expiration and publication dates:
- publication date today, expiration date tomorrow: shows
- publication date tomorrow, expiration date later: doesn't show
- publication date yesterday, expiration date today: shows
- publication date some time ago, expiration date yesterday: doesn't show
- publication date today, expiration date empty: shows

Passes all tests and QA script, no problems found.
---
 t/db_dependent/NewsChannels.t | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/t/db_dependent/NewsChannels.t b/t/db_dependent/NewsChannels.t
index f0a86e0..a70bc3f 100644
--- a/t/db_dependent/NewsChannels.t
+++ b/t/db_dependent/NewsChannels.t
@@ -3,7 +3,7 @@
 use Modern::Perl;
 use C4::Dates qw(format_date);
 use C4::Branch qw(GetBranchName);
-use Test::More tests => 10;
+use Test::More tests => 12;
 
 BEGIN {
     use_ok('C4::NewsChannels');
@@ -133,6 +133,12 @@ ok( $opac_news_count >= 2, 'Successfully tested get_opac_news for LIB1!' );
 
 # Test GetNewsToDisplay
 ( $opac_news_count, $arrayref_opac_news ) = GetNewsToDisplay( q{}, 'LIB1' );
+ok( !$arrayref_opac_news, 'Second parameter is ' .
+                          ( defined($arrayref_opac_news) ?
+                              ("Defined as '$arrayref_opac_news'") : "UNDEFINED")
+  );
+ok ( ref $opac_news_count eq 'ARRAY',
+     '$opac_news_count is an array reference');
 ok( $opac_news_count >= 2, 'Successfully tested GetNewsToDisplay for LIB1!' );
 
 $dbh->rollback;
-- 
1.9.1