From 61e9c6862d8f8bdef37b85b5575cd0060752c6bf Mon Sep 17 00:00:00 2001
From: Tomas Cohen Arazi <tomascohen@gmail.com>
Date: Tue, 12 Aug 2014 19:34:34 -0300
Subject: [PATCH] [PASSED QA] Bug 12753: Warnings in t/SIP_Sip.t could be
 tested

A C4::SIP warning is expected and should be tested.

To test:
- Run
  $ prove -v t/SIP_Sip.t
=> FAIL: A warning is printed to STDOUT
- Apply the patch
- Run
  $ prove -v t/SIP_Sip.t
=> SUCCESS: No warnings on STDOUT, a new test verifying the warning is added.
- It was an easy one, smile and sign off :-D

Sponsored-by: The Will to Procrastinate
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Sponsored-by: Sunday TV is boring
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Sponsored-by: Avoiding distance study homework
---
 t/SIP_Sip.t | 29 +++++++++++++++++++++++------
 1 file changed, 23 insertions(+), 6 deletions(-)

diff --git a/t/SIP_Sip.t b/t/SIP_Sip.t
index d837609..0346b4c 100755
--- a/t/SIP_Sip.t
+++ b/t/SIP_Sip.t
@@ -1,12 +1,24 @@
 #!/usr/bin/perl
+
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# This Koha test module is a stub!  
-# Add more tests here!!!
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
+use Modern::Perl;
 
-use Test::More tests => 8;
+use Test::More tests => 9;
+use Test::Warn;
 
 BEGIN {
         use FindBin;
@@ -39,5 +51,10 @@ my $something = Sip::Checksum::checksum($testdata);
 $something =  sprintf("%4X", $something);
 ok( Sip::Checksum::verify_cksum($testdata.$something), "Checksum: $something is valid.");
 
-my $invalidTest = Sip::Checksum::verify_cksum("1234567");
+my $invalidTest;
+warning_is { $invalidTest = Sip::Checksum::verify_cksum("1234567") }
+            'verify_cksum: no sum detected',
+            'verify_cksum prints the expected warning for an invalid checksum';
 is($invalidTest, 0, "Checksum: 1234567 is invalid as expected");
+
+1;
-- 
1.9.1