From 5ad533fa3e915bca8d12344a93af68558363e5cb Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Sat, 2 Aug 2014 21:40:35 -0300 Subject: [PATCH] [PASSED QA] Bug 12704: Remove CGI::scrolling_list from unimarc_field_225a.pl This patch removes the only instance in this file To test: 1. Apply the patch 2. If you have UNIMARC, search for a record, edit it, and go to tag 225 If you don't, edit your framework and connect this pluging to some tag/subtag 3. Clic on the plugin link. If you don't have any record that correspond to the search, can remove the commented line to have something to play 4. The collection pulldown was replaced, check that works, select a value and press Ok Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Passes tests and QA script, tested according to test plan. --- cataloguing/value_builder/unimarc_field_225a.pl | 14 ++++++-------- .../cataloguing/value_builder/unimarc_field_225a.tt | 12 +++++++++++- 2 files changed, 17 insertions(+), 9 deletions(-) diff --git a/cataloguing/value_builder/unimarc_field_225a.pl b/cataloguing/value_builder/unimarc_field_225a.pl index db3b4b8..0a0894b 100755 --- a/cataloguing/value_builder/unimarc_field_225a.pl +++ b/cataloguing/value_builder/unimarc_field_225a.pl @@ -142,14 +142,12 @@ sub plugin { } @collections = sort @collections; - # my @collections = ["test"]; - my $collection = CGI::scrolling_list( - -name => 'f1', - -values => \@collections, - -default => "$result", - -size => 1, - -multiple => 0, - ); + # my @collections = ( "test" ); + my $collection = { + values => \@collections, + default => "$result", + }; + $template->param( index => $index, collection => $collection diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt index 0e234b2..e888db1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/unimarc_field_225a.tt @@ -7,7 +7,17 @@

Collection

-

[% collection %]

+

+ +

OR new collection:
-- 1.9.1