From babd84ff92bf1c7cdf274168760c5c2bd2425dc5 Mon Sep 17 00:00:00 2001 From: Bernardo Gonzalez Kriegel Date: Fri, 1 Aug 2014 22:17:16 -0300 Subject: [PATCH] [PASSED QA] Bug 12694: Remove CGI::scrolling_list from unimarc_field_4XX.pl There are two instances on this file, but they are not used. I suppose is old code that was left dangling. Both scrolling_list, CGIPublisher and CGIitemtype, are not used on unimarc_field_4XX.tt nor any other file. Just removed from file two useless db queries. To test: 1. Apply the patch 2. If you have unimarc config, just go to one of the fields that use this plugin. If you don't, can edit you framework and change the plugin for a tag, e.g. 007. Then save fw, search and edit a record, clic to open plugin on 007 tag, check that works but don't save the original record, finally revert your changes. There must be no functional changes, is unused code. Signed-off-by: Chris Cormack Signed-off-by: Katrin Fischer Verified plugin still seems to work: - item type pull down shows up correctly - search works and choosing a record will fill subfields Passes tests and QA script. --- cataloguing/value_builder/unimarc_field_4XX.pl | 51 -------------------------- 1 file changed, 51 deletions(-) diff --git a/cataloguing/value_builder/unimarc_field_4XX.pl b/cataloguing/value_builder/unimarc_field_4XX.pl index d08102a..a473792 100755 --- a/cataloguing/value_builder/unimarc_field_4XX.pl +++ b/cataloguing/value_builder/unimarc_field_4XX.pl @@ -495,60 +495,9 @@ sub plugin { } ); - my $sth = - $dbh->prepare( - "Select itemtype,description from itemtypes order by description"); - $sth->execute; - my @itemtype; - my %itemtypes; - push @itemtype, ""; - $itemtypes{''} = ""; - while ( my ( $value, $lib ) = $sth->fetchrow_array ) { - push @itemtype, $value; - $itemtypes{$value} = $lib; - } - - my $CGIitemtype = CGI::scrolling_list( - -name => 'value', - -values => \@itemtype, - -labels => \%itemtypes, - -size => 1, - -multiple => 0 - ); - $sth->finish; - - # To show list of branches please use GetBranchesLoop() and modify template - - my $req = - $dbh->prepare( -"select distinctrow left(publishercode,45) from biblioitems order by publishercode" - ); - $req->execute; - my @select; - push @select, ""; - while ( my ($value) = $req->fetchrow ) { - push @select, $value; - } - my $CGIpublisher = CGI::scrolling_list( - -name => 'value', - -id => 'publisher', - -values => \@select, - -size => 1, - -multiple => 0 - ); - -# my $sth=$dbh->prepare("select description,itemtype from itemtypes order by description"); -# $sth->execute; -# while (my ($description,$itemtype) = $sth->fetchrow) { -# $classlist.="\n"; -# } -# $sth->finish; - my @itemtypes = C4::ItemType->all; $template->param( #classlist => $classlist, - CGIitemtype => $CGIitemtype, - CGIPublisher => $CGIpublisher, itypeloop => \@itemtypes, index => $query->param('index'), Search => 1, -- 1.9.1