From 4e8b80d2450b4045785c7fd80ddd0e9a4b89e776 Mon Sep 17 00:00:00 2001 From: Tomas Cohen Arazi Date: Tue, 26 Aug 2014 18:45:46 -0300 Subject: [PATCH] Bug 12829: (NORMARC) properly skip 020z when rendering ISBN for normal record display Currently, 020$z oocurences are not shown, but the XSLT logic used is introducing punctuation characters for those $z occurences. This patch adds a check for the existence of subfield a, and skips otherwise. To test: - Create/have a record with 020$z (one or more) but no 020$a. - Open the detail page for the record (on both OPAC and staff). => FAIL: the ISBN label and ';' and '.' characters incorrectly shown. - Repeat mixing with 020$a occurences to notice the bug. - Apply the patch, reload => SUCCES: ISBN label shows only on the presence of a 020$a, and 020$z are skipped. - Sign off :-D Regards To+ --- .../prog/en/xslt/NORMARCslim2intranetDetail.xsl | 18 ++++++++++++------ .../bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl | 18 ++++++++++++------ 2 files changed, 24 insertions(+), 12 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl b/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl index 3271e5b..316b76d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl +++ b/koha-tmpl/intranet-tmpl/prog/en/xslt/NORMARCslim2intranetDetail.xsl @@ -306,15 +306,21 @@ - - ISBN: + + ISBN: - - - .; + + + + + . + ; + + + - + ISSN: diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl index e9fd625..258cb1b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl +++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/NORMARCslim2OPACDetail.xsl @@ -326,15 +326,21 @@ - - ISBN: + + ISBN: - - - .; + + + + + . + ; + + + - + ISSN: -- 1.9.1