Bugzilla – Attachment 31448 Details for
Bug 12574
BiblioDefaultView doesn't affect XSLT results view
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12574 - BiblioDefaultView doesn't affect XSLT results view
PASSED-QA-Bug-12574---BiblioDefaultView-doesnt-aff.patch (text/plain), 3.37 KB, created by
Katrin Fischer
on 2014-09-07 22:47:33 UTC
(
hide
)
Description:
[PASSED QA] Bug 12574 - BiblioDefaultView doesn't affect XSLT results view
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-09-07 22:47:33 UTC
Size:
3.37 KB
patch
obsolete
>From 80a13944fedae2cf3f0cb70f27ad34254cc17280 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 14 Jul 2014 12:49:27 -0400 >Subject: [PATCH] [PASSED QA] Bug 12574 - BiblioDefaultView doesn't affect XSLT > results view > >The OPAC's XSLT results view does not respect the choice set in the >BiblioDefaultView system preference. This patch adds a check of the >preference to the OPAC's results view for MARC21. > >To test you must have the OPAC configured to use the XSLT view for >search results. Perform any search and test the link to a title's detail >page. Switching the values of the BiblioDefaultView should be correctly >reflected in the search results links. > >Signed-off-by: Nick Clemens <nick@quecheelibrary.org> >Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> >Works as described for XSLT view in OPAC. > >Notes: >- maybe we should change the pref text from 'simple form' to 'normal view'. >- the patch doesn't include changes to the title link generated from an 880 > field - so those links will still lead to the wrong view. >--- > .../bootstrap/en/xslt/MARC21slim2OPACResults.xsl | 18 +++++++++++++++++- > 1 file changed, 17 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >index 362cddb..f40e917 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/xslt/MARC21slim2OPACResults.xsl >@@ -30,6 +30,7 @@ > <xsl:variable name="OPACItemLocation" select="marc:sysprefs/marc:syspref[@name='OPACItemLocation']"/> > <xsl:variable name="singleBranchMode" select="marc:sysprefs/marc:syspref[@name='singleBranchMode']"/> > <xsl:variable name="OPACTrackClicks" select="marc:sysprefs/marc:syspref[@name='TrackClicks']"/> >+ <xsl:variable name="BiblioDefaultView" select="marc:sysprefs/marc:syspref[@name='BiblioDefaultView']"/> > <xsl:variable name="leader" select="marc:leader"/> > <xsl:variable name="leader6" select="substring($leader,7,1)"/> > <xsl:variable name="leader7" select="substring($leader,8,1)"/> >@@ -402,7 +403,22 @@ > </xsl:call-template> > </xsl:if> > >- <a><xsl:attribute name="href">/cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of select="$biblionumber"/></xsl:attribute><xsl:attribute name="class">title</xsl:attribute> >+ <a><xsl:attribute name="href"> >+ <xsl:choose> >+ <xsl:when test="$BiblioDefaultView='normal'"> >+ /cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of select="$biblionumber"/> >+ </xsl:when> >+ <xsl:when test="$BiblioDefaultView='isbd'"> >+ /cgi-bin/koha/opac-ISBDdetail.pl?biblionumber=<xsl:value-of select="$biblionumber"/> >+ </xsl:when> >+ <xsl:when test="$BiblioDefaultView='marc'"> >+ /cgi-bin/koha/opac-MARCdetail.pl?biblionumber=<xsl:value-of select="$biblionumber"/> >+ </xsl:when> >+ <xsl:otherwise> >+ /cgi-bin/koha/opac-detail.pl?biblionumber=<xsl:value-of select="$biblionumber"/> >+ </xsl:otherwise> >+ </xsl:choose> >+ </xsl:attribute><xsl:attribute name="class">title</xsl:attribute> > > <xsl:if test="marc:datafield[@tag=245]"> > <xsl:for-each select="marc:datafield[@tag=245]"> >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12574
:
29684
|
31330
| 31448