From 537d57d7ec572165c9eaed72299bd19aee895f4d Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Sat, 13 Sep 2014 10:49:21 +0300 Subject: [PATCH] Bug 12915 - Convert checkouts table to ajax datatable [3.16.x], AllowRenewalLimitOverride crashes datatable when user doesn't have the permission. TO REPLICATE:: load circ/circulate.pl with a user with only the following permissions: circulate_remaining_permissions catalogue observe checkouts and holds not loading. Actually this crashes all javascript on the page! --- .../intranet-tmpl/prog/en/includes/strings.inc | 2 +- .../prog/en/modules/circ/circulation.tt | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc index df9ca78..6f02b79 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc +++ b/koha-tmpl/intranet-tmpl/prog/en/includes/strings.inc @@ -3,7 +3,7 @@ var CIRCULATION_RETURNED = _("Returned"); var CIRCULATION_NOT_RETURNED = _("Unable to return"); var CIRCULATION_RENEWED_DUE = _("Renewed, due:"); - var CIRCULATION_RENEW_FAILED = _("Renew failed:") + var CIRCULATION_RENEW_FAILED = _("Renew failed:"); var NOT_CHECKED_OUT = _("not checked out"); var TOO_MANY_RENEWALS = _("too many renewals"); var ON_RESERVE = _("on reserve"); diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt index 37ed6f5..824cceb 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt @@ -32,7 +32,7 @@ var theme = "[% theme %]"; var borrowernumber = "[% borrowernumber %]"; var branchcode = "[% branch %]"; var exports_enabled = "[% exports_enabled %]"; -var AllowRenewalLimitOverride = [% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]; +var AllowRenewalLimitOverride = "[% CAN_user_circulate_override_renewals && AllowRenewalLimitOverride %]"; var relatives_borrowernumbers = new Array(); [% FOREACH b IN relatives_borrowernumbers %] relatives_borrowernumbers.push("[% b %]"); -- 1.7.9.5