From: Ian Walls To: dev@bywatersolutions.com Cc: Ian Walls Subject: [PATCH] Follow up on Bug 5462: fixing variable names breaks messaging preference form Date: Tue, 15 Feb 2011 21:29:11 -0500 Message-Id: <1297823351-31975-1-git-send-email-ian.walls@bywatersolutions.com> X-Mailer: git-send-email 1.5.6.5 X-Original-Sender: ian.walls@bywatersolutions.com X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of koha@dev.bywatersolutions.com designates 174.143.239.187 as permitted sender) smtp.mail=koha@dev.bywatersolutions.com Precedence: list Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com List-ID: List-Help: , Content-Type: text/plain; charset="utf-8" The messaging prefs form was hardcoded to use 'transport-$transport_type', rather than 'transport_$transport_type'. The result was an uneditable messaging preferences form. --- C4/Form/MessagingPreferences.pm | 2 +- C4/Members/Messaging.pm | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Form/MessagingPreferences.pm b/C4/Form/MessagingPreferences.pm index 22b2048..bd1c22f 100644 --- a/C4/Form/MessagingPreferences.pm +++ b/C4/Form/MessagingPreferences.pm @@ -132,7 +132,7 @@ sub set_form_values { } ( 0..30 ); # FIXME: 30 is a magic number. } foreach my $transport ( @{$pref->{'transports'}} ) { - $option->{'transport-'.$transport} = 'checked="checked"'; + $option->{'transport_'.$transport} = 'checked="checked"'; } $option->{'digest'} = 'checked="checked"' if $pref->{'wants_digest'}; } diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm index bc0f81b..2b39f11 100644 --- a/C4/Members/Messaging.pm +++ b/C4/Members/Messaging.pm @@ -213,7 +213,7 @@ END_SQL $choices->{ $row->{'message_name'} }->{'message_name'} = $row->{'message_name'}; $choices->{ $row->{'message_name'} }->{'takes_days'} = $row->{'takes_days'}; $choices->{ $row->{'message_name'} }->{'has_digest'} = 1 if $row->{'is_digest'}; - $choices->{ $row->{'message_name'} }->{'transport-' . $row->{'message_transport_type'}} = ' '; + $choices->{ $row->{'message_name'} }->{'transport_' . $row->{'message_transport_type'}} = ' '; } my @return = values %$choices; -- 1.5.6.5