Bugzilla – Attachment 3159 Details for
Bug 5462
Fix variable names so we dont break template::toolkit
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
follow up patch
bug5462.patch (text/plain), 2.56 KB, created by
Nicole C. Engard
on 2011-02-16 13:52:52 UTC
(
hide
)
Description:
follow up patch
Filename:
MIME Type:
Creator:
Nicole C. Engard
Created:
2011-02-16 13:52:52 UTC
Size:
2.56 KB
patch
obsolete
>From: Ian Walls <ian.walls@bywatersolutions.com> >To: dev@bywatersolutions.com >Cc: Ian Walls <ian.walls@bywatersolutions.com> >Subject: [PATCH] Follow up on Bug 5462: fixing variable names breaks messaging preference form >Date: Tue, 15 Feb 2011 21:29:11 -0500 >Message-Id: <1297823351-31975-1-git-send-email-ian.walls@bywatersolutions.com> >X-Mailer: git-send-email 1.5.6.5 >X-Original-Sender: ian.walls@bywatersolutions.com >X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: best > guess record for domain of koha@dev.bywatersolutions.com designates > 174.143.239.187 as permitted sender) smtp.mail=koha@dev.bywatersolutions.com >Precedence: list >Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com >List-ID: <dev.bywatersolutions.com> >List-Help: <http://www.google.com/support/a/bywatersolutions.com/bin/static.py?hl=en_US&page=groups.cs>, > <mailto:dev+help@bywatersolutions.com> >Content-Type: text/plain; charset="utf-8" > >The messaging prefs form was hardcoded to use 'transport-$transport_type', rather than >'transport_$transport_type'. The result was an uneditable messaging preferences form. >--- > C4/Form/MessagingPreferences.pm | 2 +- > C4/Members/Messaging.pm | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/Form/MessagingPreferences.pm b/C4/Form/MessagingPreferences.pm >index 22b2048..bd1c22f 100644 >--- a/C4/Form/MessagingPreferences.pm >+++ b/C4/Form/MessagingPreferences.pm >@@ -132,7 +132,7 @@ sub set_form_values { > } ( 0..30 ); # FIXME: 30 is a magic number. > } > foreach my $transport ( @{$pref->{'transports'}} ) { >- $option->{'transport-'.$transport} = 'checked="checked"'; >+ $option->{'transport_'.$transport} = 'checked="checked"'; > } > $option->{'digest'} = 'checked="checked"' if $pref->{'wants_digest'}; > } >diff --git a/C4/Members/Messaging.pm b/C4/Members/Messaging.pm >index bc0f81b..2b39f11 100644 >--- a/C4/Members/Messaging.pm >+++ b/C4/Members/Messaging.pm >@@ -213,7 +213,7 @@ END_SQL > $choices->{ $row->{'message_name'} }->{'message_name'} = $row->{'message_name'}; > $choices->{ $row->{'message_name'} }->{'takes_days'} = $row->{'takes_days'}; > $choices->{ $row->{'message_name'} }->{'has_digest'} = 1 if $row->{'is_digest'}; >- $choices->{ $row->{'message_name'} }->{'transport-' . $row->{'message_transport_type'}} = ' '; >+ $choices->{ $row->{'message_name'} }->{'transport_' . $row->{'message_transport_type'}} = ' '; > } > > my @return = values %$choices; >-- >1.5.6.5 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5462
:
3085
|
3109
|
3159
|
3578
|
4100
|
4299