From 7adadbe127241d4fed84b93cdaee6f51b800c10d Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Mon, 15 Sep 2014 11:38:32 +0300 Subject: [PATCH] Bug 12922 - Do not DIE the advance_notices.pl -cronjob if no letter of type is found!! --- misc/cronjobs/advance_notices.pl | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl index 62e36e4..26f87ae 100755 --- a/misc/cronjobs/advance_notices.pl +++ b/misc/cronjobs/advance_notices.pl @@ -266,7 +266,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { message_transport_type => $transport, } ) or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; - push @letters, $letter; + push @letters, $letter if $letter; } } } else { @@ -302,7 +302,7 @@ UPCOMINGITEM: foreach my $upcoming ( @$upcoming_dues ) { message_transport_type => $transport, } ) or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; - push @letters, $letter; + push @letters, $letter if $letter; } } } @@ -376,8 +376,8 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$upcoming_digest ) { message_transport_type => $transport, } ) - or die "no letter of type '$letter_type' found. Please see sample_notices.sql"; - push @letters, $letter; + or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + push @letters, $letter if $letter; } if ( @letters ) { @@ -434,8 +434,8 @@ PATRON: while ( my ( $borrowernumber, $digest ) = each %$due_digest ) { message_transport_type => $transport, } ) - or die "no letter of type '$letter_type' found. Please see sample_notices.sql"; - push @letters, $letter; + or warn "no letter of type '$letter_type' found. Please see sample_notices.sql"; + push @letters, $letter if $letter; } if ( @letters ) { -- 1.7.9.5