From 5e800260d3fd46ad2bac4a241746ddaaa76930b7 Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Tue, 4 Mar 2014 12:58:28 -0500 Subject: [PATCH] Bug 11634 [QA Followup] - Unit Tests These new unit tests will fail due to the fact that Koha::Database uses a separate dbh handle than C4::Context->dbh --- t/db_dependent/Circulation.t | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t index 1740795..a284c4f 100755 --- a/t/db_dependent/Circulation.t +++ b/t/db_dependent/Circulation.t @@ -26,7 +26,7 @@ use C4::Reserves; use Koha::DateUtils; use Koha::Database; -use Test::More tests => 55; +use Test::More tests => 57; BEGIN { use_ok('C4::Circulation'); @@ -282,6 +282,13 @@ C4::Context->dbh->do("DELETE FROM accountlines"); $title, $checkitem, $found ); + C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 1 ); + ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber); + is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds'); + ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber2); + is( $renewokay, 1, 'Bug 11634 - Allow renewal of item with unfilled holds if other available items can fill those holds'); + C4::Context->set_preference('AllowRenewalIfOtherItemsAvailable', 0 ); + ( $renewokay, $error ) = CanBookBeRenewed($renewing_borrowernumber, $itemnumber); is( $renewokay, 0, '(Bug 10663) Cannot renew, reserved'); is( $error, 'on_reserve', '(Bug 10663) Cannot renew, reserved (returned error is on_reserve)'); -- 1.7.2.5