From d3f5ac0901c01088939ebf64eb06a8e3f76f8391 Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Wed, 17 Sep 2014 08:31:27 -0400 Subject: [PATCH] [PASSED QA] Bug 12937 [Follow-up] Deleting suggestions should ask for a confirmation This minor follow-up revises the language a bit: Adding missing question marks and using the more standard prompt "Please select at least one..." To test, follow the previous test plan and confirm that the prompts are improved: - go on the suggestion management page - don't select any suggestion and try to delete (check the checkbox and submit the form). Verify that you get an alert. - select 1 suggestion and delete it, verify you get a confirmation message - select 1+ suggestions and delete it, verify you get a confirmation message Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- .../prog/en/modules/suggestion/suggestion.tt | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt index 70d00ad..e3096c3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt @@ -141,16 +141,16 @@ $(document).ready(function() { if ( action_delete_selected ) { var suggestions_to_delete = $(this).find("input[name='edit_field']:checked"); if ( suggestions_to_delete.length == 0 ) { - alert(_("No suggestion to delete")); + alert(_("Please select at least one suggestion to delete")); e.preventDefault(); return false; } else if ( suggestions_to_delete.length == 1 ) { - if ( ! confirm(_("Are you sure you want to delete this suggestion")) ) { + if ( ! confirm(_("Are you sure you want to delete this suggestion?")) ) { e.preventDefault(); return false; } } else if ( suggestions_to_delete.length > 1 ) { - if ( ! confirm(_("Are you sure you want to delete these suggestions")) ) { + if ( ! confirm(_("Are you sure you want to delete these suggestions?")) ) { e.preventDefault(); return false; } -- 1.7.2.5