Bugzilla – Attachment 31883 Details for
Bug 6279
Can't delete lists from the second page of lists in the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6279: Cannot delete lists from second page of lists in the OPAC
Bug-6279-Cannot-delete-lists-from-second-page-of-l.patch (text/plain), 3.20 KB, created by
Marcel de Rooy
on 2014-09-25 15:28:16 UTC
(
hide
)
Description:
Bug 6279: Cannot delete lists from second page of lists in the OPAC
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2014-09-25 15:28:16 UTC
Size:
3.20 KB
patch
obsolete
>From 5ca28632d975e756387cfe4cd3f5b576d3b45b1e Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Thu, 25 Sep 2014 17:21:13 +0200 >Subject: [PATCH] Bug 6279: Cannot delete lists from second page of lists in > the OPAC >Content-Type: text/plain; charset=utf-8 > >The code in Page.pm still needs more attention, but this may serve as >a quick fix for the problem; it will at least improve the situation. > >If you delete a list from its individual page (viewshelf), you already >see the items (if any). So we will assume that after you said Yes to the >message box, you want to delete it. There will not be a confirmation >button anymore. >Note that after you deleted the list, the intended message is not shown and >the pagination bar is gone. I leave those for the future refactoring. > >Test plan: >Delete a list from its own viewshelf page in OPAC and staff. >Note that OPAC will delete it rightaway now. >Note that staff still has the confirmation button. >--- > C4/VirtualShelves/Page.pm | 7 +------ > .../opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 1 + > 2 files changed, 2 insertions(+), 6 deletions(-) > >diff --git a/C4/VirtualShelves/Page.pm b/C4/VirtualShelves/Page.pm >index 56518c2..fa0ded0 100644 >--- a/C4/VirtualShelves/Page.pm >+++ b/C4/VirtualShelves/Page.pm >@@ -362,13 +362,9 @@ sub shelfpage { > > #Deleting a shelf (asking for confirmation if it has entries) > foreach ( $query->param() ) { >- /(DEL|REMSHR)-(\d+)/ or next; >+ /(DEL|REMSHR)-(\d+)$/ or next; > $delflag = 1; > my $number = $2; >- unless ( defined $shelflist->{$number} || defined $privshelflist->{$number} ) { >- push( @paramsloop, { unrecognized => $number } ); >- last; >- } > #remove a share > if(/REMSHR/) { > RemoveShare($loggedinuser, $number); >@@ -377,7 +373,6 @@ sub shelfpage { > $stay=0; > next; > } >- # > unless ( ShelfPossibleAction( $loggedinuser, $number, 'manage' ) ) { > push( @paramsloop, { nopermission => $shelfnumber } ); > last; >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >index a65be1b..b6374ac 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt >@@ -176,6 +176,7 @@ > <form method="post" action="/cgi-bin/koha/opac-shelves.pl" class="form-inline"> > <input type="hidden" value="1" name="shelves"/> > <input type="hidden" value="1" name="DEL-[% shelfnumber %]"/> >+ <input type="hidden" value="1" name="CONFIRM-[% shelfnumber %]"/> > [% IF ( showprivateshelves ) %] > <input type="hidden" name="display" value="privateshelves"/> > [% END %] >-- >1.7.7.6
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6279
:
15627
|
31883
|
31892
|
31893
|
31894
|
31898
|
31899