From: ruth@bywatersolutions.com To: dev@bywatersolutions.com Cc: D Ruth Bavousett Subject: [PATCH] Bug 5805: Having items in-transit can cause derangement of the hold list Date: Thu, 24 Feb 2011 21:50:49 -0500 Message-Id: <1298602249-1835-1-git-send-email-ruth@bywatersolutions.com> X-Mailer: git-send-email 1.7.2.3 X-Original-Sender: ruth@bywatersolutions.com X-Original-Authentication-Results: mx.google.com; spf=neutral (google.com: 209.85.212.42 is neither permitted nor denied by best guess record for domain of ruth@bywatersolutions.com) smtp.mail=ruth@bywatersolutions.com X-Google-Group-Id: -607656515 Precedence: list Mailing-list: list dev@bywatersolutions.com; contact dev+owners@bywatersolutions.com List-ID: List-Help: , If you have a list of holds on a biblio, and one or more are in-transit, then the array that is fed to modrequest.pl is not fully-populated, lacking the branch on the in-transit rows. If you then attempt to edit one of the remaining holds' pickup location, it doesn't modify the one you expect, but ones *above* that. Also, holds at the bottom of the list get the first pickup library in the list, since they are getting undef passed in. --- .../prog/en/modules/reserve/request.tmpl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl index 58a5ad9..53ff7b7 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tmpl @@ -639,7 +639,7 @@ function checkMultiHold() { Item waiting at " /> - Waiting to be pulled + Waiting to be pulled " /> Item being transferred to " /> -- 1.7.2.3