Bugzilla – Attachment 32221 Details for
Bug 12005
Zebra searches sometimes fail silently under Plack
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12005: Remove useless parameters
Bug-12005-Remove-useless-parameters.patch (text/plain), 1.84 KB, created by
Jonathan Druart
on 2014-10-10 21:38:45 UTC
(
hide
)
Description:
Bug 12005: Remove useless parameters
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-10-10 21:38:45 UTC
Size:
1.84 KB
patch
obsolete
>From 4af90ce17642003d969a1613465682fb1295fb8d Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Fri, 10 Oct 2014 23:34:10 +0200 >Subject: [PATCH] Bug 12005: Remove useless parameters > >C4::Context::Zconn subroutine takes too much more paramters. >This subroutine is never called with more that 2 parameters. >Others can be removed. > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Context.pm | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > >diff --git a/C4/Context.pm b/C4/Context.pm >index c87e7e2..f8f71cd 100644 >--- a/C4/Context.pm >+++ b/C4/Context.pm >@@ -680,14 +680,11 @@ C<$server> one of the servers defined in the koha-conf.xml file > > C<$async> whether this is a asynchronous connection > >-C<$auth> whether this connection has rw access (1) or just r access (0 or NULL) >- >- > =cut > > sub Zconn { >- my ($self, $server, $async, $auth, $piggyback, $syntax) = @_; >- my $connection = _new_Zconn( $server, $async, $piggyback ); >+ my ($self, $server, $async) = @_; >+ my $connection = _new_Zconn( $server, $async ); > return $connection; > } > >@@ -706,7 +703,7 @@ C<$auth> whether this connection has rw access (1) or just r access (0 or NULL) > =cut > > sub _new_Zconn { >- my ( $server, $async, $piggyback ) = @_; >+ my ( $server, $async ) = @_; > > my $tried=0; # first attempt > my $Zconn; # connection object >@@ -742,7 +739,6 @@ sub _new_Zconn { > $o->option(user => $user) if $user && $password; > $o->option(password => $password) if $user && $password; > $o->option(async => 1) if $async; >- $o->option(count => $piggyback) if $piggyback; > $o->option(cqlfile=> $context->{"server"}->{$server}->{"cql2rpn"}); > $o->option(cclfile=> $context->{"serverinfo"}->{$server}->{"ccl2rpn"}); > $o->option(preferredRecordSyntax => $syntax); >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12005
:
32102
|
32194
|
32218
|
32221
|
32334
|
32404
|
32417
|
32429