From 233c4ef7f5c3afd98553402bb7e8606d69c85f52 Mon Sep 17 00:00:00 2001 From: Olli-Antti Kivilahti Date: Wed, 8 Oct 2014 15:22:53 +0300 Subject: [PATCH] Bug 11990 - Holds ratio report (circ/reserveratios.pl) sorts numeric values as text This patch makes columns Holds, Items and "Hold ratio" to sort numerically instead of lexicographically. Also changes default sorting column from "Holds" to "Hold ratio" because this is a hold ratios -report, not hold count report. Also cleans up an excess aoColumn -definition, because aoColumns == aoColumnDefs without target operator. No point in defining columns twice. Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart --- .../intranet-tmpl/prog/en/modules/circ/reserveratios.tt | 17 +++-------------- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt index dcc9d50..b12ffc3 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/reserveratios.tt @@ -15,21 +15,10 @@ function () { $(this).toggleClass("ulined") } ); $("#holdst").dataTable($.extend(true, {}, dataTablesDefaults, { - "aaSorting": [ [0,'desc'], [3,'asc'] ], + "aaSorting": [ [2,'desc'], [3,'asc'] ], "aoColumnDefs": [ - { "aTargets": [ 8 ], "sType": "natural" }, - { "aTargets": [ 3 ], "sType": "anti-the" } - ], - "aoColumns": [ - null, - null, - null, - { "sType": "anti-the" }, - null, - null, - null, - null, - null + { "aTargets": [ 0,1,2,8 ], "sType": "natural" }, + { "aTargets": [ 3 ], "sType": "anti-the" }, ], "sPaginationType": "four_button" })); -- 2.1.0