Bugzilla – Attachment 32510 Details for
Bug 12862
HTML fixes triggered by cleaning up language="javascript"
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete.
PASSED-QA-Bug-12862-CCSR-and-Prog---languagejavasc.patch (text/plain), 6.96 KB, created by
Kyle M Hall
on 2014-10-17 14:41:45 UTC
(
hide
)
Description:
[PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete.
Filename:
MIME Type:
Creator:
Kyle M Hall
Created:
2014-10-17 14:41:45 UTC
Size:
6.96 KB
patch
obsolete
>From 9d224a9198e819bd0bd6e71dbc5636a62b23ea86 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Tue, 2 Sep 2014 17:58:01 -0400 >Subject: [PATCH] [PASSED QA] Bug 12862: CCSR and Prog - language="javascript" is obsolete. > >Corrected/removed the obsolete HTML. >Fixed a hard coded opac-tmpl, as per koha-qa's demand. > >Trigger all the templates and check of the language="javascript" >error is listed in the validation done by the HTML Validator >plugin for FireFox that Owen pointed me at. > >TEST PLAN >--------- >1) Test with opactheme set to ccsr. Any opac page with > opac-bottom.inc will do. >2) Test with opactheme set to prog. > - Any opac page with opac-bottom.inc > - Any opac page with doc-head-close.inc > - Advanced search > - Authority search -> Submit -> View full heading -> MARC View > - staff client, home, serials, submit by the title text box, > click one of the subscriptions > (you don't have subscriptions?! can't help you), > determine the biblionumber, opac, > search for the biblio number and get to an opac details page, > click on more details >3) Test the self-checkout printslip, just like the bootstrap > one previously. > >Signed-off-by: Owen Leonard <oleonard@myacpl.org> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > .../opac-tmpl/ccsr/en/includes/opac-bottom.inc | 2 +- > .../opac-tmpl/prog/en/includes/doc-head-close.inc | 4 ++-- > .../opac-tmpl/prog/en/includes/opac-bottom.inc | 2 +- > .../opac-tmpl/prog/en/modules/opac-advsearch.tt | 4 ++-- > .../prog/en/modules/opac-auth-MARCdetail.tt | 4 ++-- > .../prog/en/modules/opac-full-serial-issues.tt | 2 +- > .../opac-tmpl/prog/en/modules/sco/printslip.tt | 5 ++++- > 7 files changed, 13 insertions(+), 10 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/ccsr/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/ccsr/en/includes/opac-bottom.inc >index 3f8bf66..7a1abaa 100644 >--- a/koha-tmpl/opac-tmpl/ccsr/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/ccsr/en/includes/opac-bottom.inc >@@ -94,7 +94,7 @@ $(function() { > > [% IF persona %] > <script src="https://login.persona.org/include.js"></script> >-<script type="text/javascript" language="javascript"> >+<script type="text/javascript"> > > navigator.id.watch({ > loggedInUser: [% IF emailaddress && loggedinpersona %]'[% emailaddress %]'[% ELSE %]null[% END %], >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >index 66666f4..f9ad60e 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/doc-head-close.inc >@@ -37,11 +37,11 @@ > <script type="text/javascript" src="[% themelang %]/lib/jquery/plugins/jquery.hoverIntent.minified.js"></script> > <script type="text/javascript" src="[% themelang %]/js/script.js"></script> > [% IF ( OPACAmazonCoverImages ) %] >-<script type="text/javascript" language="javascript">//<![CDATA[ >+<script type="text/javascript">//<![CDATA[ > var NO_AMAZON_IMAGE = _("No cover image available"); > //]]> > </script> >-<script type="text/javascript" language="javascript" src="[% themelang %]/js/amazonimages.js"></script> >+<script type="text/javascript" src="[% themelang %]/js/amazonimages.js"></script> > [% END %] > [% IF ( SyndeticsCoverImages ) %] > <script type="text/javascript">//<![CDATA[ >diff --git a/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >index ec17f80..6dc25d2 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >+++ b/koha-tmpl/opac-tmpl/prog/en/includes/opac-bottom.inc >@@ -60,7 +60,7 @@ > > [% IF persona %] > <script src="https://login.persona.org/include.js"></script> >-<script type="text/javascript" language="javascript"> >+<script type="text/javascript"> > > navigator.id.watch({ > loggedInUser: [% IF emailaddress && loggedinpersona %]'[% emailaddress %]'[% ELSE %]null[% END %], >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt >index 04ab78c..90eac35 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-advsearch.tt >@@ -3,7 +3,7 @@ > [% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] > catalog › Advanced search > [% INCLUDE 'doc-head-close.inc' %] >-<script type="text/javascript" language="javascript">//<![CDATA[ >+<script type="text/javascript">//<![CDATA[ > $(document).ready(function() { > $('#advsearches').tabs(); > }); >@@ -343,7 +343,7 @@ > <!-- /SEARCH BUTTONS --></div></div> > </form> > </div> >-<script type="text/javascript" language="javascript"> >+<script type="text/javascript"> > /* This function allows to display a new field to search. > */ > $(document).on("click", '.ButtonPlus', function(e) { >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt >index 11481d9..89d0a02 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-auth-MARCdetail.tt >@@ -2,8 +2,8 @@ > [% PROCESS 'opac-authorities.inc' %] > [% INCLUDE 'doc-head-open.inc' %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Entry > [% INCLUDE 'doc-head-close.inc' %] >-<script language="javascript" type="text/javascript" src="/opac-tmpl/lib/jquery/plugins/jquery.jstree.js"></script> >-<script language="javascript" type="text/javascript"> >+<script type="text/javascript" src="[% interface %]/lib/jquery/plugins/jquery.jstree.js"></script> >+<script type="text/javascript"> > //<![CDATA[ > $(document).ready(function() { > [% IF ( displayhierarchy ) %] >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt >index ab48058..943f89a 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt >@@ -3,7 +3,7 @@ > [% INCLUDE 'doc-head-open.inc' %][% IF ( LibraryNameTitle ) %][% LibraryNameTitle %][% ELSE %]Koha online[% END %] catalog › Subscription information for [% bibliotitle %] > [% INCLUDE 'doc-head-close.inc' %] > [% INCLUDE 'datatables.inc' %] >-<script type="text/javascript" language="javascript"> >+<script type="text/javascript"> > //<![CDATA[ > > $(document).ready(function(){ >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/sco/printslip.tt b/koha-tmpl/opac-tmpl/prog/en/modules/sco/printslip.tt >index 4708384..7737147 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/sco/printslip.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/sco/printslip.tt >@@ -7,7 +7,7 @@ > <link rel="stylesheet" type="text/css" href="[% stylesheet %]" /> > [% END %] > >-<script language="javascript"> >+<script type="text/javascript"> > function printThenClose() { > window.print(); > window.close(); >@@ -24,3 +24,6 @@ > [% ELSE %] > [% slip %] > [% END %] >+</div> >+</body> >+</html> >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12862
:
31325
|
31326
|
31327
|
32186
|
32187
|
32188
|
32508
|
32509
| 32510