From 521e70f81d9fe5a8819319d53b4d6c21b127433c Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Fri, 17 Oct 2014 08:39:19 -0400 Subject: [PATCH] Bug 13104 - Changing date or time format on a production server will create duplicate fines! The system preference TimeFormat decides if times are formatted in 24 hour or 12 hour format. The issue at hand is that this changes the time description for fines. Let us assume the time format is currently 24 hour, and there are overdue items with accruing fines. When the format is changed to 12 hour, and fines.pl is run, it will begin looking for fines with a 12 hour format. Since there are no, it will create a new fine and you will now have two fines for the same item! There are solutions which require database manipulation: 1) Update all existing fines from 24 hour to 12 hour format 2) Delete all existing accruing fines so they are all regenerated the following night The same situation applies to DateFormat. The accounts rewrite ( Bug 6427 ) will resolve this issue, as it does not look for existing fines based on the description. I believe the best course of action until bug 6427 is pushed to master is to add a warning to the system preference to not alter it on a production server with existing fines. Signed-off-by: Chris Cormack --- .../intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref index 02985d3..dde2f09 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/i18n_l10n.pref @@ -7,7 +7,7 @@ I18N/L10N: us: mm/dd/yyyy metric: dd/mm/yyyy iso: yyyy-mm-dd - - . + - . Note: Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines! - - Format times in - pref: TimeFormat @@ -15,7 +15,7 @@ I18N/L10N: choices: 24hr: 24 hour format ( e.g. "14:18" ) 12hr: 12 hour format ( e.g. "02:18 PM" ) - - . + - . Note: Do not change this preference on a production server with overdue items that are accruing fines. Doing so will result in duplicate fines! - - Use - pref: CalendarFirstDayOfWeek -- 1.9.1