Bugzilla – Attachment 3290 Details for
Bug 4374
Data entry form doesn't use hidden/mandatory flag as expected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Proposed patch
0001-Bug-4374-Improve-biblio-data-entry-form-regarding-hi.patch (text/plain), 2.39 KB, created by
Frédéric Demians
on 2011-03-14 05:47:55 UTC
(
hide
)
Description:
Proposed patch
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2011-03-14 05:47:55 UTC
Size:
2.39 KB
patch
obsolete
>From a38c51ea3592405e42b129a147f718d722bad894 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Wed, 7 Apr 2010 07:35:00 +0200 >Subject: [PATCH] Bug 4374 Improve biblio data entry form regarding hidden/mandatory fields > >Biblio framework has 3 entry points controlling if input box are >displayed by default in data entry form: > > - 'mandatory' flag at field level > - 'mandatory' flag at subfield level > - 'hidden' flag at subfield level > >It doesn't work as it should (?): > > - All subfields are expanded (shown) if their field is mandatory > - A subfield containing anything is always expanded whatever it contains > - A mandatory subfield is always expanded > - An hidden subfield isn't expanded. > >Default framework having 0 in all marc_subfield_structure.hidden, by default >all subfields will be expanded. > >TO BE INTEGRATED IN RELEASE NOTES: > > Koha sysadmin should have to edit its frameworks to add hidden=1 in > appropriate subfields. >--- > cataloguing/addbiblio.pl | 14 +++++++------- > 1 files changed, 7 insertions(+), 7 deletions(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index da58166..0463b7d 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -341,14 +341,14 @@ sub create_input { > if(exists $mandatory_z3950->{$tag.$subfield}){ > $subfield_data{z3950_mandatory} = $mandatory_z3950->{$tag.$subfield}; > } >- # decide if the subfield must be expanded (visible) by default or not >- # if it is mandatory, then expand. If it is hidden explicitly by the hidden flag, hidden anyway >+ # Subfield is hidden depending of hidden and mandatory flag, and is always >+ # shown if it contains anything or if its field is mandatory. >+ my $tdef = $tagslib->{$tag}; > $subfield_data{visibility} = "display:none;" >- if ( ($tagslib->{$tag}->{$subfield}->{hidden} % 2 == 1) and $value ne '' >- or ($value eq '' and !$tagslib->{$tag}->{$subfield}->{mandatory}) >- ); >- # always expand all subfields of a mandatory field >- $subfield_data{visibility} = "" if $tagslib->{$tag}->{mandatory}; >+ if $tdef->{$subfield}->{hidden} % 2 == 1 && >+ $value eq '' && >+ !$tdef->{$subfield}->{mandatory} && >+ !$tdef->{mandatory}; > # it's an authorised field > if ( $tagslib->{$tag}->{$subfield}->{authorised_value} ) { > $subfield_data{marc_value} = >-- >1.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 4374
: 3290