From 997a3ffdbe782ea2c71d985bf4cfb9e21088334b Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 30 Oct 2014 09:57:49 -0400 Subject: [PATCH] [PASSED QA] Bug 12258 [Template follow-up] Datatable in Patrons Account Fines MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This follow-up corrects some of the QA issues affecting the other patch, as well as changing the way the "filter" option is displayed: - Added the use of the DataTables include file - Removed redundant document.ready - Fixed single quotes - Fixed default sort (should be date descending to match the current functionality) - Adding missing - Converted filter button to a link The last change is a judgement call, but the button in the DataTables toolbar looked awkward and caused ugly wrapping at narrower viewport sizes. I think a link is more keeping with the pattern established by "select all / clear all" links. To test, apply both patches and view the account page (members/boraccount.pl) for a patron who has paid and unpaid fines (the more the better). - Confirm that the default sort is by date descending. - Confirm that DataTables controls (paging, search, result count) work correctly. - Confirm that clicking the "Filter paid transactions" link works correctly to toggle display of paid transactions. Works as expected. Passed koha-qa.pl. Signed-off-by: Marc VĂ©ron Signed-off-by: Katrin Fischer Works as described, no problems found. Passes QA script and tests. --- .../prog/en/modules/members/boraccount.tt | 50 +++++++++++----------- 1 file changed, 26 insertions(+), 24 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt index b6c06d9..f87c475 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt @@ -1,32 +1,32 @@ [% INCLUDE 'doc-head-open.inc' %] Koha › Patrons › Account for [% INCLUDE 'patron-title.inc' %] [% INCLUDE 'doc-head-close.inc' %] - - -[% INCLUDE 'datatables-strings.inc' %] - - +}); + [% INCLUDE 'header.inc' %] @@ -54,15 +54,17 @@ - - - - - - [% IF ( reverse_col ) %] - - [% END %] - + + + + + + + [% IF ( reverse_col ) %] + + [% END %] + + -- 1.9.1
DateDescription of chargesNoteAmountOutstanding Print
DateDescription of chargesNoteAmountOutstanding Print