From 6aa477858615af52a564eb5c44fb73683a82a737 Mon Sep 17 00:00:00 2001
From: Olli-Antti Kivilahti <olli-antti.kivilahti@jns.fi>
Date: Fri, 31 Oct 2014 16:40:18 +0200
Subject: [PATCH] Bug 13180 - While acquiring from the new improved staged
 file, warning "Indicator in 952 is empty at
 /home/koha/kohaclone/C4/Biblio.pm" is flooding the bejesus
 out of my koha-error.log

I get one warning for each mapped Koha items field.

This patch fakes the missing indicators to the addorderiso2709.pl/.tt.
Those indicators don't really exists for field 952 anyway.
---
 acqui/addorderiso2709.pl                           |    4 ++--
 .../prog/en/modules/acqui/addorderiso2709.tt       |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/acqui/addorderiso2709.pl b/acqui/addorderiso2709.pl
index 15c83ea..a0fbfd0 100755
--- a/acqui/addorderiso2709.pl
+++ b/acqui/addorderiso2709.pl
@@ -268,6 +268,7 @@ if ($op eq ""){
             my @subfields    = $input->param('subfield');
             my @field_values = $input->param('field_value');
             my @serials      = $input->param('serial');
+            my @indicator   = $input->param('indicator'); #Passing the imaginary empty "  " -indicators from the templates, to stop C4::Biblio::TransformHtmlToXml() to warn the bejesus out of my koha-error.log
             my @ind_tag   = $input->param('ind_tag');
             my @indicator = $input->param('indicator');
             my $item;
@@ -275,8 +276,7 @@ if ($op eq ""){
             push @{ $item->{subfields} },    $subfields[0];
             push @{ $item->{field_values} }, $field_values[0];
             push @{ $item->{ind_tag} },      $ind_tag[0];
-            push @{ $item->{indicator} },    $indicator[0];
-            my $xml = TransformHtmlToXml( \@tags, \@subfields, \@field_values, \@ind_tag, \@indicator );
+            my $xml = TransformHtmlToXml( \@tags, \@subfields, \@field_values, \@indicator, \@ind_tag );
             my $record = MARC::Record::new_from_xml( $xml, 'UTF-8' );
             for (my $qtyloop=1;$qtyloop <= $c_quantity;$qtyloop++) {
                 my ( $biblionumber, $bibitemnum, $itemnumber ) = AddItemFromMarc( $record, $biblionumber );
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
index cf03b7c..1578093 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt
@@ -299,6 +299,7 @@
                                         <input type="hidden" name="itemid" value="1" />
                                         <input type="hidden" name="kohafield" value="[% iteminformatio.kohafield %]" />
                                         <input type="hidden" name="tag" value="[% iteminformatio.tag %]" />
+                                        <input type="hidden" name="indicator" value="  " /> [%#Pass imaginary indicators to stop warnings in C4::Biblio::TransformHtmlToXml() %]
                                         <input type="hidden" name="subfield" value="[% iteminformatio.subfield %]" />
                                         <input type="hidden" name="mandatory" value="[% iteminformatio.mandatory %]" />
                                         [% IF ( iteminformatio.mandatory ) %] <span class="required">Required</span>[% END %]
-- 
1.7.9.5