Bugzilla – Attachment 33239 Details for
Bug 12630
Prioritizing "Hold starts on date" -holds causes all other holds to be prioritized as well!
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 12630 [QA Followup] - Rename _ShiftPriorityByDateAndPriority to _ShiftPriority
Bug-12630-QA-Followup---Rename-ShiftPriorityByDate.patch (text/plain), 1.75 KB, created by
Jonathan Druart
on 2014-11-05 09:33:55 UTC
(
hide
)
Description:
Bug 12630 [QA Followup] - Rename _ShiftPriorityByDateAndPriority to _ShiftPriority
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2014-11-05 09:33:55 UTC
Size:
1.75 KB
patch
obsolete
>From 52c0b70502d49453eec22a0d43c827f2da895558 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Mon, 25 Aug 2014 10:17:28 -0400 >Subject: [PATCH] Bug 12630 [QA Followup] - Rename > _ShiftPriorityByDateAndPriority to _ShiftPriority > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > C4/Reserves.pm | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/C4/Reserves.pm b/C4/Reserves.pm >index a1cc1a7..b549e4a 100644 >--- a/C4/Reserves.pm >+++ b/C4/Reserves.pm >@@ -166,7 +166,7 @@ sub AddReserve { > } > if ( C4::Context->preference( 'AllowHoldDateInFuture' ) ) { > # Make room in reserves for this before those of a later reserve date >- $priority = _ShiftPriorityByDateAndPriority( $biblionumber, $priority ); >+ $priority = _ShiftPriority( $biblionumber, $priority ); > } > my $waitingdate; > >@@ -2015,9 +2015,9 @@ sub _koha_notify_reserve { > > } > >-=head2 _ShiftPriorityByDateAndPriority >+=head2 _ShiftPriority > >- $new_priority = _ShiftPriorityByDateAndPriority( $biblionumber, $reservedate, $priority ); >+ $new_priority = _ShiftPriority( $biblionumber, $priority ); > > This increments the priority of all reserves after the one > with either the lowest date after C<$reservedate> >@@ -2033,7 +2033,7 @@ the sub accounts for that too. > > =cut > >-sub _ShiftPriorityByDateAndPriority { >+sub _ShiftPriority { > my ( $biblio, $new_priority ) = @_; > > my $dbh = C4::Context->dbh; >@@ -2330,7 +2330,7 @@ priority is based on the set of holds whose start date falls before > the parameter value. > > After calculation of this priority, it is recommended to call >-_ShiftPriorityByDateAndPriority. Note that this is currently done in >+_ShiftPriority. Note that this is currently done in > AddReserves. > > =cut >-- >2.1.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12630
:
29962
|
31140
|
31141
|
33238
|
33239
|
33240
|
135939
|
135940
|
135941
|
135942