Bugzilla – Attachment 33278 Details for
Bug 12627
SQLHelper replacement - C4::Suggestions
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 12627: Remove warnings
PASSED-QA-Bug-12627-Remove-warnings.patch (text/plain), 1.14 KB, created by
Katrin Fischer
on 2014-11-05 21:39:32 UTC
(
hide
)
Description:
[PASSED QA] Bug 12627: Remove warnings
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2014-11-05 21:39:32 UTC
Size:
1.14 KB
patch
obsolete
>From 7ce87831ef2874b2411a82759d5ca662023e75f9 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@biblibre.com> >Date: Mon, 29 Sep 2014 15:24:36 +0200 >Subject: [PATCH] [PASSED QA] Bug 12627: Remove warnings > >suggestion.pl: keys on reference is experimental > >Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> >--- > suggestion/suggestion.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/suggestion/suggestion.pl b/suggestion/suggestion.pl >index 72f40d3..211daa8 100755 >--- a/suggestion/suggestion.pl >+++ b/suggestion/suggestion.pl >@@ -98,7 +98,7 @@ my $suggestion_ref = $input->Vars; > # get only the columns of Suggestion > my $schema = Koha::Database->new()->schema; > my $columns = ' '.join(' ', $schema->source('Suggestion')->columns).' '; >-my $suggestion_only = { map { $columns =~ / $_ / ? ($_ => $suggestion_ref->{$_}) : () } keys($suggestion_ref) }; >+my $suggestion_only = { map { $columns =~ / $_ / ? ($_ => $suggestion_ref->{$_}) : () } keys %$suggestion_ref }; > $suggestion_only->{STATUS} = $suggestion_ref->{STATUS}; > > delete $$suggestion_ref{$_} foreach qw( suggestedbyme op displayby tabcode edit_field ); >-- >1.9.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 12627
:
29963
|
30095
|
30237
|
30269
|
30624
|
30635
|
30892
|
31916
|
31917
|
31937
|
31939
|
31940
|
31941
|
31942
|
31944
|
31948
|
31953
|
33244
|
33276
|
33277
| 33278 |
33279
|
33280
|
33281