From ca0d550a6b3943740b0fd8d7a9f9b8d22afdf443 Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Wed, 5 Nov 2014 12:41:13 +0100 Subject: [PATCH] [SIGNED OFF] Bug 13201: GetSuggestion takes suggestionid Having $ordernumber as the parameter in a function which is handling suggestions and it is used as a suggestion id is confusing to the coder and person trying to read the code. This patch corrects the confusion. REVISED TEST PLAN ----------------- 1) perldoc C4::Suggestions -- notice it says ordernumber for the GetSuggestions example. 2) Ensure you have CPL in your branches table. 3) prove -v t/db_dependent/Suggestions.t -- if you have more than 8 itemtypes in your database, two tests at the end will fail, but that is not relevant to the modified GetSuggestions code. 4) apply patch 5) perldoc C4::Suggestions -- notice it is corrected now. 6) prove -v t/db_dependent/Suggestions.t -- it should run with the same results as in step 3. That is, if you have 8 itemtypes, all pass, otherwise those two tests fail. 7) run koha qa test tool Signed-off-by: Mark Tompsett --- C4/Suggestions.pm | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/C4/Suggestions.pm b/C4/Suggestions.pm index b543293..dbc3e5e 100644 --- a/C4/Suggestions.pm +++ b/C4/Suggestions.pm @@ -201,9 +201,9 @@ sub SearchSuggestion { =head2 GetSuggestion -\%sth = &GetSuggestion($ordernumber) +\%sth = &GetSuggestion($suggestionid) -this function get the detail of the suggestion $ordernumber (input arg) +this function get the detail of the suggestion $suggestionid (input arg) return : the result of the SQL query as a hash : $sth->fetchrow_hashref. @@ -211,7 +211,7 @@ return : =cut sub GetSuggestion { - my ($ordernumber) = @_; + my ($suggestionid) = @_; my $dbh = C4::Context->dbh; my $query = q{ SELECT * @@ -219,7 +219,7 @@ sub GetSuggestion { WHERE suggestionid=? }; my $sth = $dbh->prepare($query); - $sth->execute($ordernumber); + $sth->execute($suggestionid); return ( $sth->fetchrow_hashref ); } -- 1.7.9.5