From 5454de9ca0acb602c8d7145d04c43414091ef9aa Mon Sep 17 00:00:00 2001 From: Kyle M Hall Date: Thu, 13 Nov 2014 12:03:42 -0500 Subject: [PATCH] Bug 12778 - Regression: Item lost status doesn't show in list of checkouts When using the longoverdue script it's possible that items marked lost remain on the patron account. I think it's important for staff to see that some items are marked lost - currently the list of checkouts doesn't show any sign of the lost status. Test Plan: 1) Find a patron with a checked out lost item 2) Note the lost status is not displayed in the checkouts table 3) Apply this patch 4) Refresh the page, note the lost status now displays --- koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js | 12 +++++++++--- svc/checkouts | 7 +++++-- 2 files changed, 14 insertions(+), 5 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js index e333776..9e58d21 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js +++ b/koha-tmpl/intranet-tmpl/prog/en/js/checkouts.js @@ -183,11 +183,17 @@ $(document).ready(function() { { "iDataSort": 1, // Sort on hidden unformatted date due column "mDataProp": function( oObj ) { + var due = oObj.date_due_formatted; + if ( oObj.date_due_overdue ) { - return "" + oObj.date_due_formatted + ""; - } else { - return oObj.date_due_formatted; + due = "" + due + ""; } + + if ( oObj.lost ) { + due += "" + oObj.lost + ""; + } + + return due; } }, { diff --git a/svc/checkouts b/svc/checkouts index 9dc4881..7ac848e 100755 --- a/svc/checkouts +++ b/svc/checkouts @@ -25,8 +25,8 @@ use JSON qw(to_json); use C4::Auth qw(check_cookie_auth); use C4::Biblio qw(GetMarcBiblio GetFrameworkCode GetRecordValue ); -use C4::Circulation - qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate); +use C4::Circulation qw(GetIssuingCharges CanBookBeRenewed GetRenewCount GetSoonestRenewDate); +use C4::Koha qw(GetAuthorisedValueByCode); use C4::Context; use Koha::DateUtils; @@ -86,6 +86,8 @@ my $sql = ' firstname, cardnumber, + itemlost, + DATEDIFF( issuedate, CURRENT_DATE() ) AS not_issued_today FROM issues LEFT JOIN items USING ( itemnumber ) @@ -175,6 +177,7 @@ while ( my $c = $sth->fetchrow_hashref() ) { GetMarcBiblio( $c->{biblionumber} ), GetFrameworkCode( $c->{biblionumber} ) ), + lost => GetAuthorisedValueByCode( 'LOST', $c->{itemlost} ), borrower => { surname => $c->{surname}, firstname => $c->{firstname}, -- 1.7.2.5