From 1c626a97ba9e96f2310ad53eb18d22df3bf4cfb0 Mon Sep 17 00:00:00 2001 From: Benjamin Rokseth Date: Tue, 8 Apr 2014 14:24:56 +0200 Subject: [PATCH] Bug 12043 - Popup when reserved item checked in at wrong branch should generate transfer slip This patch corrects some wrong popups in Returns.tt handling transfers of reserved items. Instead of using hold-transfer-slip.pl with param transfer=1 (which seems to be silently ignored) it uses transfer-slip.pl with itemnumber and destination branch, which allows for printing correct slips. It also removes the non-used param $tranfer in hold-transfer-slip.pl. Test plan: ( see cases in bug description ) 1) Make a reservation on item with homebranch A to branch B 2) checkin item at its homebranch A 3) press 'Print slip and confirm transfer' 4) verify that slip uses template RESERVESLIP 5) apply patch 6) repeat steps 1-3 7) verify that slip now uses template TRANSFERSLIP Signed-off-by: Nick Clemens --- circ/hold-transfer-slip.pl | 1 - 1 file changed, 1 deletion(-) diff --git a/circ/hold-transfer-slip.pl b/circ/hold-transfer-slip.pl index 525e25a..42cb1b9 100755 --- a/circ/hold-transfer-slip.pl +++ b/circ/hold-transfer-slip.pl @@ -38,7 +38,6 @@ my $session = get_session($sessionID); my $biblionumber = $input->param('biblionumber'); my $borrowernumber = $input->param('borrowernumber'); -my $transfer = $input->param('transfer'); my ( $template, $loggedinuser, $cookie ) = get_template_and_user( { -- 1.7.10.4